Skip to content

Conversation

@urkud
Copy link
Member

@urkud urkud commented Jan 6, 2026

The lemma and the typo were introduced in #33508


Do we need to introduce a deprecated alias? The typo was introduced ~1 day ago.

Open in Gitpod

fix(Finprod): fix a to_additive name

The lemma and the typo were introduced in #33508

The lemma and the typo were introduced in leanprover-community#33508
@github-actions github-actions bot added the t-algebra Algebra (groups, rings, fields, etc) label Jan 6, 2026
@github-actions
Copy link

github-actions bot commented Jan 6, 2026

PR summary b66f9a38d1

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@urkud urkud added the easy < 20s of review time. See the lifecycle page for guidelines. label Jan 6, 2026
@ocfnash
Copy link
Contributor

ocfnash commented Jan 6, 2026

bors merge

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the ready-to-merge This PR has been sent to bors. label Jan 6, 2026
mathlib-bors bot pushed a commit that referenced this pull request Jan 6, 2026
The lemma and the typo were introduced in #33508
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Jan 6, 2026

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title fix(Finprod): fix a to_additive name [Merged by Bors] - fix(Finprod): fix a to_additive name Jan 6, 2026
@mathlib-bors mathlib-bors bot closed this Jan 6, 2026
@urkud urkud deleted the fix-name branch January 8, 2026 17:04
goliath-klein pushed a commit to PrParadoxy/mathlib4 that referenced this pull request Jan 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

easy < 20s of review time. See the lifecycle page for guidelines. ready-to-merge This PR has been sent to bors. t-algebra Algebra (groups, rings, fields, etc)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants