Skip to content

Conversation

@Hagb
Copy link
Collaborator

@Hagb Hagb commented Dec 12, 2025

This commit adds a variant sPolynomial_mul_monomial', using m.degree (monomial d c * p) instead of d + m.degree p, which are different in the edge case that one of c and p is 0.

A pair of variants about leadingTerm instead of monomial are also added.


Open in Gitpod

@github-actions
Copy link

github-actions bot commented Dec 12, 2025

PR summary 4d33172004

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ sPolynomial_leadingTerm_mul
+ sPolynomial_leadingTerm_mul'
+ sPolynomial_monomial_mul
+ sPolynomial_monomial_mul'
- sPolynomial_mul_monomial

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@erdOne
Copy link
Member

erdOne commented Dec 13, 2025

Again weird lemmas for weird Gröbner bases.
Thanks!
maintainer merge

@github-actions
Copy link

🚀 Pull request has been placed on the maintainer queue by erdOne.

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. label Dec 13, 2025
@jcommelin jcommelin added awaiting-author A reviewer has asked the author a question or requested changes. and removed maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. labels Dec 15, 2025
@Hagb Hagb removed the awaiting-author A reviewer has asked the author a question or requested changes. label Dec 15, 2025
@jcommelin
Copy link
Member

Thanks 🎉

bors merge

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the ready-to-merge This PR has been sent to bors. label Dec 15, 2025
mathlib-bors bot pushed a commit that referenced this pull request Dec 15, 2025
…olynomial_mul_monomial` (#32788)

This commit adds a variant `sPolynomial_mul_monomial'`, using `m.degree (monomial d c * p)` instead of `d + m.degree p`, which are different in the edge case that one of `c` and `p` is 0.

A pair of variants about `leadingTerm` instead of `monomial` are also added.
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Dec 15, 2025

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat(RingTheory/MvPolynomial/MonomialOrder): add some variants of sPolynomial_mul_monomial [Merged by Bors] - feat(RingTheory/MvPolynomial/MonomialOrder): add some variants of sPolynomial_mul_monomial Dec 15, 2025
@mathlib-bors mathlib-bors bot closed this Dec 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge This PR has been sent to bors. t-ring-theory Ring theory

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants