-
Notifications
You must be signed in to change notification settings - Fork 1k
[Merged by Bors] - feat(NumberTheory/EisensteinSeries/E2): Define the Eisenstein series E2 #32584
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - feat(NumberTheory/EisensteinSeries/E2): Define the Eisenstein series E2 #32584
Conversation
PR summary 789a3095b5Import changes exceeding 2%
|
| File | Base Count | Head Count | Change |
|---|---|---|---|
| Mathlib.Topology.Algebra.InfiniteSum.ConditionalInt | 735 | 1123 | +388 (+52.79%) |
Import changes for all files
| Files | Import difference |
|---|---|
Mathlib.Topology.Algebra.InfiniteSum.ConditionalInt |
388 |
Mathlib.NumberTheory.ModularForms.EisensteinSeries.E2.Defs (new file) |
2460 |
Mathlib.NumberTheory.ModularForms.EisensteinSeries.E2.Summable (new file) |
2590 |
Declarations diff
+ D2
+ D2_S
+ D2_T
+ D2_inv
+ D2_mul
+ D2_one
+ E2
+ G2
+ G2_eq_tsum_cexp
+ G2_eq_tsum_symmetricIco
+ _root_.HasProd.hasProd_symmetricIco_of_hasProd_symmetricIcc
+ _root_.Summable.tendsto_zero_of_even_summable_symmetricIcc
+ e2Summand
+ e2Summand_even
+ e2Summand_summable
+ e2Summand_zero_eq_two_riemannZeta_two
+ hasSum_e2Summand_symmetricIcc
+ hasSum_e2Summand_symmetricIco
+ multipliable_symmetricIco_of_multipliable_symmetricIcc
+ summable_e2Summand_symmetricIcc
+ summable_e2Summand_symmetricIco
+ tendsto_e2Summand_atTop_nhds_zero
- HasProd.hasProd_symmetricIco_of_hasProd_symmetricIcc
- multipliable_symmetricIco_of_multiplible_symmetricIcc
You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>The doc-module for script/declarations_diff.sh contains some details about this script.
No changes to technical debt.
You can run this locally as
./scripts/technical-debt-metrics.sh pr_summary
- The
relativevalue is the weighted sum of the differences with weight given by the inverse of the current value of the statistic. - The
absolutevalue is therelativevalue divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).
Mathlib/NumberTheory/ModularForms/EisensteinSeries/E2/Defs.lean
Outdated
Show resolved
Hide resolved
loefflerd
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First instalment, more later
Mathlib/NumberTheory/ModularForms/EisensteinSeries/E2/Defs.lean
Outdated
Show resolved
Hide resolved
loefflerd
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here's some (not definitive) feedback on the second file. Overall I feel like it's a bit roundabout, like we keep taking 2 steps forward and 1 step back (establishing that a sequence tends to some limit & then deducing that it's Cauchy, etc)
Mathlib/NumberTheory/ModularForms/EisensteinSeries/E2/Summable.lean
Outdated
Show resolved
Hide resolved
Mathlib/NumberTheory/ModularForms/EisensteinSeries/E2/Summable.lean
Outdated
Show resolved
Hide resolved
Mathlib/NumberTheory/ModularForms/EisensteinSeries/E2/Summable.lean
Outdated
Show resolved
Hide resolved
Mathlib/NumberTheory/ModularForms/EisensteinSeries/E2/Summable.lean
Outdated
Show resolved
Hide resolved
Mathlib/NumberTheory/ModularForms/EisensteinSeries/E2/Summable.lean
Outdated
Show resolved
Hide resolved
Mathlib/NumberTheory/ModularForms/EisensteinSeries/E2/Summable.lean
Outdated
Show resolved
Hide resolved
Mathlib/NumberTheory/ModularForms/EisensteinSeries/E2/Summable.lean
Outdated
Show resolved
Hide resolved
|
This might help: |
|
See https://pastebin.com/GJ30AWGE for a suggestion about how to edit the |
loefflerd
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good now!
maintainer delegate
Mathlib/NumberTheory/ModularForms/EisensteinSeries/E2/Summable.lean
Outdated
Show resolved
Hide resolved
|
🚀 Pull request has been placed on the maintainer queue by loefflerd. |
Co-authored-by: David Loeffler <d.loeffler.01@cantab.net>
|
(Maintainers: CB has implemented the changes I wanted so please consider my "maintainer delegate" to be upgraded to "maintainer merge") |
jcommelin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks 🎉
bors merge
|
Build failed (retrying...): |
|
Pull request successfully merged into master. Build succeeded: |
From leanprover-community#33633, leanprover-community#30563, leanprover-community#33771, leanprover-community#33755, leanprover-community#31988, leanprover-community#33622, leanprover-community#32837, leanprover-community#33638, leanprover-community#33503, leanprover-community#33321, leanprover-community#33242, leanprover-community#32955, leanprover-community#33159, leanprover-community#33152, leanprover-community#33131, leanprover-community#33144, leanprover-community#32116, leanprover-community#31259, leanprover-community#26831, leanprover-community#32917, leanprover-community#32589, leanprover-community#32584, leanprover-community#32562, leanprover-community#32788, and leanprover-community#32568.
From leanprover-community#33633, leanprover-community#30563, leanprover-community#33771, leanprover-community#33755, leanprover-community#31988, leanprover-community#33622, leanprover-community#32837, leanprover-community#33638, leanprover-community#33503, leanprover-community#33321, leanprover-community#33242, leanprover-community#32955, leanprover-community#33159, leanprover-community#33152, leanprover-community#33131, leanprover-community#33144, leanprover-community#32116, leanprover-community#31259, leanprover-community#26831, leanprover-community#32917, leanprover-community#32589, leanprover-community#32584, leanprover-community#32562, leanprover-community#32788, and leanprover-community#32568.
From leanprover-community#33633, leanprover-community#30563, leanprover-community#33771, leanprover-community#33755, leanprover-community#31988, leanprover-community#33622, leanprover-community#32837, leanprover-community#33638, leanprover-community#33503, leanprover-community#33321, leanprover-community#33242, leanprover-community#32955, leanprover-community#33159, leanprover-community#33152, leanprover-community#33131, leanprover-community#33144, leanprover-community#32116, leanprover-community#31259, leanprover-community#26831, leanprover-community#32917, leanprover-community#32589, leanprover-community#32584, leanprover-community#32562, leanprover-community#32788, and leanprover-community#32568.
From leanprover-community#33633, leanprover-community#30563, leanprover-community#33771, leanprover-community#33755, leanprover-community#31988, leanprover-community#33622, leanprover-community#32837, leanprover-community#33638, leanprover-community#33503, leanprover-community#33321, leanprover-community#33242, leanprover-community#32955, leanprover-community#33159, leanprover-community#33152, leanprover-community#33131, leanprover-community#33144, leanprover-community#32116, leanprover-community#31259, leanprover-community#26831, leanprover-community#32917, leanprover-community#32589, leanprover-community#32584, leanprover-community#32562, leanprover-community#32788, and leanprover-community#32568.
We define the Eisenstein series E2 and prove some basic results which will be needed in #32585 to prove how it transforms under the slash action of SL2.