Skip to content

Conversation

@CBirkbeck
Copy link
Collaborator

@CBirkbeck CBirkbeck commented Dec 16, 2025

This contains a series of lemmas that are needed in #32585 to prove how E2 transforms under the slash action.


Open in Gitpod

@github-actions github-actions bot added the file-removed A Lean module was (re)moved without a `deprecated_module` annotation label Dec 19, 2025
@CBirkbeck CBirkbeck removed the awaiting-author A reviewer has asked the author a question or requested changes. label Dec 19, 2025
@CBirkbeck
Copy link
Collaborator Author

Note I renamed a file (fixing a typo in the name) so the file was not actually removed.

@loefflerd
Copy link
Collaborator

The thing to do with the removed file is to not completely delete the old file, but move its contents elsewhere and keep the old file containing nothing but a deprecation warning, like this:

module

public import Name.Of.The.New.File

deprecated_module (since := "2025-12-19")

See Mathlib.Topology.PartialHomeomorph for an example. Then it will get autodeleted after 6 months. (I agree this is a bit overkill for this example, but the CI scripts will complain otherwise.)

@github-actions github-actions bot removed the file-removed A Lean module was (re)moved without a `deprecated_module` annotation label Dec 19, 2025
Copy link
Collaborator

@loefflerd loefflerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks good now.

maintainer delegate

@github-actions
Copy link

🚀 Pull request has been placed on the maintainer queue by loefflerd.

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. label Dec 23, 2025
@riccardobrasca
Copy link
Member

Thanks!

bors d+

@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Dec 24, 2025

✌️ CBirkbeck can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). and removed maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. labels Dec 24, 2025
@loefflerd
Copy link
Collaborator

This was failing CI due to some glitch in the testing system, unrelated to the PR. I just re-ran the failing test and it works fine now.

@CBirkbeck
Copy link
Collaborator Author

bors r+

mathlib-bors bot pushed a commit that referenced this pull request Dec 27, 2025
…ary E2 lemmas (#32955)

This contains a series of lemmas that are needed in #32585 to prove how E2 transforms under the slash action.

Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com>
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Dec 27, 2025

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat(NumberTheory/ModularForms/EisensteinSeries/Summable): add auxiliary E2 lemmas [Merged by Bors] - feat(NumberTheory/ModularForms/EisensteinSeries/Summable): add auxiliary E2 lemmas Dec 27, 2025
@mathlib-bors mathlib-bors bot closed this Dec 27, 2025
kim-em pushed a commit to kim-em/mathlib4 that referenced this pull request Jan 6, 2026
…ary E2 lemmas (leanprover-community#32955)

This contains a series of lemmas that are needed in leanprover-community#32585 to prove how E2 transforms under the slash action.

Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com>
goliath-klein pushed a commit to PrParadoxy/mathlib4 that referenced this pull request Jan 24, 2026
…ary E2 lemmas (leanprover-community#32955)

This contains a series of lemmas that are needed in leanprover-community#32585 to prove how E2 transforms under the slash action.

Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). t-number-theory Number theory (also use t-algebra or t-analysis to specialize)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants