Skip to content

Conversation

@kebekus
Copy link
Collaborator

@kebekus kebekus commented Dec 21, 2025

Following a discussion of Zulip, this very short PR ports the first functions to use the new predicate Meromorphic. Introduce two fun_props along the way. A much more massive PR that ports Value Distribution Theory will follow in a separate PR.

#mathlib4 > Introducing Meromorphic @ 💬


Open in Gitpod

@github-actions github-actions bot added the t-analysis Analysis (normed *, calculus) label Dec 21, 2025
@github-actions
Copy link

github-actions bot commented Dec 21, 2025

PR summary 3cfe59e733

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ MeromorphicOn.countable_compl_analyticAt
+ MeromorphicOn.measurable
+ inv
+ smul

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@kebekus kebekus marked this pull request as ready for review December 21, 2025 09:14
@kebekus kebekus requested a review from j-loreaux December 21, 2025 09:14
@j-loreaux
Copy link
Collaborator

I don't think we generally include the new declaration Meromorphic.meromorphicOn_univ. It would need to be protected if we did, but you should also just be able to use Meromorphic.meromorphicOn. When Lean can infer univ, it works, and when it can't, you can simply supply the implicit argument manually.

@j-loreaux j-loreaux added the awaiting-author A reviewer has asked the author a question or requested changes. label Dec 21, 2025
@grunweg grunweg changed the title feat: Use new predicate Meromorphic feat: use new predicate Meromorphic Dec 21, 2025
@kebekus
Copy link
Collaborator Author

kebekus commented Dec 21, 2025

Removed Meromorphic.meromorphicOn_univ as suggested by @j-loreaux

@kebekus kebekus removed the awaiting-author A reviewer has asked the author a question or requested changes. label Dec 21, 2025
@j-loreaux
Copy link
Collaborator

bors merge

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the ready-to-merge This PR has been sent to bors. label Dec 22, 2025
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Dec 22, 2025

Merge conflict.

@mathlib4-merge-conflict-bot mathlib4-merge-conflict-bot added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Dec 22, 2025
@mathlib4-merge-conflict-bot
Copy link
Collaborator

This pull request has conflicts, please merge master and resolve them.

@github-actions github-actions bot removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Dec 22, 2025
@kebekus
Copy link
Collaborator Author

kebekus commented Dec 22, 2025

@j-loreaux The merge conflict is now fixed.

@j-loreaux
Copy link
Collaborator

Thanks!

bors merge

mathlib-bors bot pushed a commit that referenced this pull request Dec 22, 2025
Following a discussion of Zulip, this very short PR ports the first functions to use the new predicate `Meromorphic`. Introduce two `fun_prop`s along the way. A much more massive PR that ports Value Distribution Theory will follow in a separate PR.

[#mathlib4 > Introducing `Meromorphic` @ 💬](https://leanprover.zulipchat.com/#narrow/channel/287929-mathlib4/topic/Introducing.20.60Meromorphic.60/near/564522177)
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Dec 22, 2025

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat: use new predicate Meromorphic [Merged by Bors] - feat: use new predicate Meromorphic Dec 22, 2025
@mathlib-bors mathlib-bors bot closed this Dec 22, 2025
@kebekus kebekus deleted the kebekus/meromorphic.2 branch December 23, 2025 08:22
kim-em pushed a commit to kim-em/mathlib4 that referenced this pull request Jan 6, 2026
Following a discussion of Zulip, this very short PR ports the first functions to use the new predicate `Meromorphic`. Introduce two `fun_prop`s along the way. A much more massive PR that ports Value Distribution Theory will follow in a separate PR.

[#mathlib4 > Introducing `Meromorphic` @ 💬](https://leanprover.zulipchat.com/#narrow/channel/287929-mathlib4/topic/Introducing.20.60Meromorphic.60/near/564522177)
goliath-klein pushed a commit to PrParadoxy/mathlib4 that referenced this pull request Jan 24, 2026
Following a discussion of Zulip, this very short PR ports the first functions to use the new predicate `Meromorphic`. Introduce two `fun_prop`s along the way. A much more massive PR that ports Value Distribution Theory will follow in a separate PR.

[#mathlib4 > Introducing `Meromorphic` @ 💬](https://leanprover.zulipchat.com/#narrow/channel/287929-mathlib4/topic/Introducing.20.60Meromorphic.60/near/564522177)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge This PR has been sent to bors. t-analysis Analysis (normed *, calculus)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants