refactor(ga): simplify ReciprocalFrame with clearer loop structure#553
Merged
utensil merged 3 commits intopygae:masterfrom Mar 31, 2026
Merged
Conversation
Replace the convoluted index/combinations approach with a clearer loop that directly computes E as the wedge of all basis vectors, then forms each reciprocal vector by wedging all basis vectors except the i-th and multiplying by E with the appropriate sign. Fixes #5
The reciprocal frame fix (issue pygae#249) changes the signs of the reciprocal vectors, making eu.eu_r = 1 instead of -1. Update the saved notebook output to reflect the mathematically correct results.
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Member
|
Thanks for the cleanup — the loop structure is much cleaner. One math issue: the sign formula The correct sign is sgn = S.NegativeOne ** iPlease also add a 2D test case to ga2, e1, e2 = Ga.build('e*1|2', g=[1, 1])
basis2 = [e1 + e2, e1 - e2]
r_basis2 = ga2.ReciprocalFrame(basis2)
for i, base in enumerate(basis2):
for j, rbase in enumerate(r_basis2):
assert (base | rbase).simplify() == (1 if i == j else 0) |
The sign (-1)^(n-1-i) was wrong for even-dimensional frames (e.g. 2D), giving eu.eu_r = -1 instead of 1. The correct sign is (-1)^i (moving basis[i] to position 0 requires exactly i transpositions). Add 2D test case to catch even-dimension sign bugs.
Contributor
Author
|
Good catch on the sign formula. Fixed:
Pushed in 741a586. |
utiberious
added a commit
to utiberious/galgebra
that referenced
this pull request
Apr 1, 2026
Groups new entries by: features, bug fixes, examples/docs, tests/maintenance. Features: Cl() kingdon interface (pygae#550, closes pygae#524), Mv.__rtruediv__ (pygae#543, closes pygae#512), shirokov_inverse/hitzer_inverse (pygae#530). Bugs: interop dual mode contamination (pygae#556, closes pygae#555), norm() Abs wrapping (pygae#554, closes pygae#522), is_versor() improvement (pygae#536, closes pygae#533). Examples/docs: sundial + cheatsheet tests (pygae#549+pygae#557, closes pygae#506), coords tutorial (pygae#551), README ops (pygae#548, closes pygae#523). Tests/maintenance: lt.matrix() regression tests (pygae#558, closes pygae#461), extra-cdot regression test (pygae#545), er_blade + ReciprocalFrame refactors (pygae#552+pygae#553), CI fix (pygae#535).
utensil
pushed a commit
that referenced
this pull request
Apr 1, 2026
* docs: add 0.6.0 changelog entries Groups new entries by: features, bug fixes, examples/docs, tests/maintenance. Features: Cl() kingdon interface (#550, closes #524), Mv.__rtruediv__ (#543, closes #512), shirokov_inverse/hitzer_inverse (#530). Bugs: interop dual mode contamination (#556, closes #555), norm() Abs wrapping (#554, closes #522), is_versor() improvement (#536, closes #533). Examples/docs: sundial + cheatsheet tests (#549+#557, closes #506), coords tutorial (#551), README ops (#548, closes #523). Tests/maintenance: lt.matrix() regression tests (#558, closes #461), extra-cdot regression test (#545), er_blade + ReciprocalFrame refactors (#552+#553), CI fix (#535). * docs: add missing issue link for #551 entry * docs: add changelog entry for #560 (Lt callable zero fix) * docs: move Lt zero fix into bug group, use issue #540 as reference
utiberious
added a commit
to utiberious/galgebra
that referenced
this pull request
Apr 2, 2026
utiberious
added a commit
to utiberious/galgebra
that referenced
this pull request
Apr 2, 2026
* docs: add 0.6.0 changelog entries Groups new entries by: features, bug fixes, examples/docs, tests/maintenance. Features: Cl() kingdon interface (pygae#550, closes pygae#524), Mv.__rtruediv__ (pygae#543, closes pygae#512), shirokov_inverse/hitzer_inverse (pygae#530). Bugs: interop dual mode contamination (pygae#556, closes pygae#555), norm() Abs wrapping (pygae#554, closes pygae#522), is_versor() improvement (pygae#536, closes pygae#533). Examples/docs: sundial + cheatsheet tests (pygae#549+pygae#557, closes pygae#506), coords tutorial (pygae#551), README ops (pygae#548, closes pygae#523). Tests/maintenance: lt.matrix() regression tests (pygae#558, closes pygae#461), extra-cdot regression test (pygae#545), er_blade + ReciprocalFrame refactors (pygae#552+pygae#553), CI fix (pygae#535). * docs: add missing issue link for pygae#551 entry * docs: add changelog entry for pygae#560 (Lt callable zero fix) * docs: move Lt zero fix into bug group, use issue pygae#540 as reference
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Simplifies the
ReciprocalFrameimplementation with a cleaner loop structure while preserving the mathematical correctness of the reciprocal frame computation.Fixes #249
Changes
galgebra/ga.py: RestructureReciprocalFramewith clearer variable naming and simplified loopexamples/ipython/Old Format.ipynb: Update notebook outputs to match corrected reciprocal frame (reciprocal vectors now satisfye_i . e^j = delta_ij)Test plan