Skip to content

fix(mv): improve is_versor() per GSG's analysis#536

Merged
utensil merged 7 commits intomasterfrom
is_versor
Mar 31, 2026
Merged

fix(mv): improve is_versor() per GSG's analysis#536
utensil merged 7 commits intomasterfrom
is_versor

Conversation

@utensil
Copy link
Copy Markdown
Member

@utensil utensil commented Mar 25, 2025

Fixes #533

@utensil utensil mentioned this pull request Mar 25, 2025
Closed
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 25, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 88.88889% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 73.39%. Comparing base (574c6c3) to head (7bed42e).
⚠️ Report is 11 commits behind head on master.

Files with missing lines Patch % Lines
galgebra/mv.py 88.88% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #536      +/-   ##
==========================================
- Coverage   78.93%   73.39%   -5.54%     
==========================================
  Files          19       22       +3     
  Lines        4452     4458       +6     
==========================================
- Hits         3514     3272     -242     
- Misses        938     1186     +248

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@utensil utensil added this to the 0.6.0 milestone Mar 31, 2026
@utensil
fix(mv): remove justfile, clean up test setUp, use :issue: link
f96206b 
- Remove justfile (moved to utensil/add-justfile branch)
- Remove unused basis vector assignments in TestVersors.setUp
- Use :issue:`533` RST role instead of bare URL in is_versor docstring
@utensil
Copy link
Copy Markdown
Member Author

utensil commented Mar 31, 2026 •
edited
Loading

Coming back to this PR after a year and reviewing:

  • Separated the justfile to utensil/add-justfile branch so it can be tracked separately. Removed from this PR.
  • Cleaned up dead code in TestVersors.setUp (basis vectors were assigned but never used — each test re-extracts them).
  • Changed the issue link in the docstring to use :issue:\533`` for consistency with the docs.

@utensil utensil changed the title Improve is_versor() per GSG's analysis fix(mv): improve is_versor() per GSG's analysis Mar 31, 2026
@utensil utensil merged commit 1a27cc7 into master Mar 31, 2026
10 of 11 checks passed
@utensil utensil added bug component: core Ga, Mv, Metric, etc labels Mar 31, 2026
utiberious added a commit to utiberious/galgebra that referenced this pull request Apr 1, 2026
@utiberious
docs: add 0.6.0 changelog entries
ba4f9fc 
Groups new entries by: features, bug fixes, examples/docs, tests/maintenance.

Features: Cl() kingdon interface (pygae#550, closes pygae#524), Mv.__rtruediv__
(pygae#543, closes pygae#512), shirokov_inverse/hitzer_inverse (pygae#530).

Bugs: interop dual mode contamination (pygae#556, closes pygae#555), norm() Abs
wrapping (pygae#554, closes pygae#522), is_versor() improvement (pygae#536, closes pygae#533).

Examples/docs: sundial + cheatsheet tests (pygae#549+pygae#557, closes pygae#506),
coords tutorial (pygae#551), README ops (pygae#548, closes pygae#523).

Tests/maintenance: lt.matrix() regression tests (pygae#558, closes pygae#461),
extra-cdot regression test (pygae#545), er_blade + ReciprocalFrame refactors
(pygae#552+pygae#553), CI fix (pygae#535).
@utiberious utiberious mentioned this pull request Apr 1, 2026
Merged
utensil pushed a commit that referenced this pull request Apr 1, 2026
@utiberious
docs: add 0.6.0 changelog entries (#559)
965b4c2 
* docs: add 0.6.0 changelog entries

Groups new entries by: features, bug fixes, examples/docs, tests/maintenance.

Features: Cl() kingdon interface (#550, closes #524), Mv.__rtruediv__
(#543, closes #512), shirokov_inverse/hitzer_inverse (#530).

Bugs: interop dual mode contamination (#556, closes #555), norm() Abs
wrapping (#554, closes #522), is_versor() improvement (#536, closes #533).

Examples/docs: sundial + cheatsheet tests (#549+#557, closes #506),
coords tutorial (#551), README ops (#548, closes #523).

Tests/maintenance: lt.matrix() regression tests (#558, closes #461),
extra-cdot regression test (#545), er_blade + ReciprocalFrame refactors
(#552+#553), CI fix (#535).

* docs: add missing issue link for #551 entry

* docs: add changelog entry for #560 (Lt callable zero fix)

* docs: move Lt zero fix into bug group, use issue #540 as reference
utiberious pushed a commit to utiberious/galgebra that referenced this pull request Apr 2, 2026
@utensil
fix(mv): improve is_versor() per GSG's analysis (pygae#536)
1cadd18
utiberious added a commit to utiberious/galgebra that referenced this pull request Apr 2, 2026
@utiberious
docs: add 0.6.0 changelog entries (pygae#559)
9376474 
* docs: add 0.6.0 changelog entries

Groups new entries by: features, bug fixes, examples/docs, tests/maintenance.

Features: Cl() kingdon interface (pygae#550, closes pygae#524), Mv.__rtruediv__
(pygae#543, closes pygae#512), shirokov_inverse/hitzer_inverse (pygae#530).

Bugs: interop dual mode contamination (pygae#556, closes pygae#555), norm() Abs
wrapping (pygae#554, closes pygae#522), is_versor() improvement (pygae#536, closes pygae#533).

Examples/docs: sundial + cheatsheet tests (pygae#549+pygae#557, closes pygae#506),
coords tutorial (pygae#551), README ops (pygae#548, closes pygae#523).

Tests/maintenance: lt.matrix() regression tests (pygae#558, closes pygae#461),
extra-cdot regression test (pygae#545), er_blade + ReciprocalFrame refactors
(pygae#552+pygae#553), CI fix (pygae#535).

* docs: add missing issue link for pygae#551 entry

* docs: add changelog entry for pygae#560 (Lt callable zero fix)

* docs: move Lt zero fix into bug group, use issue pygae#540 as reference
@utensil utensil mentioned this pull request Apr 2, 2026
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

bug component: core Ga, Mv, Metric, etc

Projects

None yet

Milestone

0.6.0

Development

Successfully merging this pull request may close these issues.

.is_versor() method in class Mv of module mv.py uses an incorrect algorithm

1 participant

@utensil