Simplify the implementation of ReciprocalFrame#249
Closed
eric-wieser wants to merge 1 commit intopygae:masterfrom
Closed
Simplify the implementation of ReciprocalFrame#249eric-wieser wants to merge 1 commit intopygae:masterfrom
eric-wieser wants to merge 1 commit intopygae:masterfrom
Conversation
eric-wieser
added
component: docs
eric-wieser
force-pushed
the
tidy-ReciprocalFrame
branch
2 times, most recently
from
1e0bc39 to
32c90c0
Compare
This is fewer lines and more comments
eric-wieser
force-pushed
the
tidy-ReciprocalFrame
branch
from
32c90c0 to
f3ffc03
Compare
eric-wieser
changed the title
utiberious
added a commit
to utiberious/galgebra
that referenced
this pull request
Mar 31, 2026
The reciprocal frame fix (issue pygae#249) changes the signs of the reciprocal vectors, making eu.eu_r = 1 instead of -1. Update the saved notebook output to reflect the mathematically correct results.
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is fewer lines and more comments