[STAGE] Stratconn-2841 #772
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add option to choose a custom bucket --------- Co-authored-by: Varadarajan V <109586712+varadarajan-tw@users.noreply.github.com> Co-authored-by: Varadarajan V <vvijayaragavan@twilio.com>
* fixes typo and related test some test were returning false positive, update the way to check on them * bump package version to 1.2.1 --------- Co-authored-by: Varadarajan V <vvijayaragavan@twilio.com>
* UMD need window.require * Update version
Added this property to test on stage branch
…js-integrations into STRATCONN2841
AnkitSegment
added a commit
that referenced
this pull request
Aug 4, 2023
This reverts commit 2a89693.
AnkitSegment
added a commit
that referenced
this pull request
Aug 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added this property to test on stage branch
What does this PR do?
Includes custom event_id as propertyMap,
Jira tickets: https://segment.atlassian.net/browse/STRATCONN-2841?atlOrigin=eyJpIjoiOTc4ZjFhMTIyNTkyNDk3NGJjNTQwMzdjYzc5MWEzNjAiLCJwIjoiaiJ9
Are there breaking changes in this PR?
NO
Testing
Not able to run in local branch merging into stage to test
Testing not required
Any background context you want to provide?
Is there parity with the server-side/android/iOS integration components (if applicable)?
Does this require a new integration setting? If so, please explain how the new setting works
Links to helpful docs and other external resources