Add option to choose a custom bucket #759

paco-walkme · 2023-06-01T11:28:56Z

New option for certain customers to have a private bucket inside AWS

Testing completed successfully via unit tests.

but using `users` instead a custom name as we dont need to create a temporary directory on S3, the actual literal use is not important

varadarajan-tw

LGTM! There seems to be a typo in the option name. Depending on the name, I'll create a new option in partner portal for walk me and proceed with the deploy.

integrations/walkme/lib/index.js

varadarajan-tw · 2023-07-06T16:14:38Z

Hey @paco-walkme, it seems like Custom Directory setting has already been created with the typo and option key is customDirecotry. I am unable to delete it. I think we have to revert the typo fix changes and use customDirecotry as the option key :(

integrations/walkme/lib/index.js

…ortal

varadarajan-tw · 2023-07-18T04:22:50Z

I reverted the key to customDirecotry

varadarajan-tw · 2023-07-19T06:02:26Z

Hey @paco-walkme – I will be initiating deployment today. The rollout will be done in three phases over the next three days to reduce risk.

Phase 1 - 19 Jul
Phase 2- 20 Jul
Phase 3 - 21 Jul

If you would like to test this change in Segment production before the full rollout, please share ID of the source connected to your walkme destination in your workspace. I can help deploy this change to your source only for validation.

paco-walkme · 2023-07-19T06:09:02Z

Hello there! We would love to test the change. Here is the ID 5b312c44-4264-4eb2-a523-650801cf610e I don't think i ever done this type of testing in prod, is there a reference in the documentation about this testing section? Thanks!

…

On Wed, Jul 19, 2023 at 8:02 AM Varadarajan V ***@***.***> wrote: Hey @paco-walkme <https://github.com/paco-walkme> – I will be initiating deployment today. The rollout will be done in three phases over the next three days to reduce risk. 1. Phase 1 - 19 Jul 2. Phase 2- 20 Jul 3. Phase 3 - 21 Jul If you would like to test this change in Segment production before the full rollout, please share ID of the source connected to your walkme destination in your workspace. I can help deploy this change to your source only for validation. — Reply to this email directly, view it on GitHub <#759 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ADUKDX7GS2UVLOS7AIC75RDXQ5Z73ANCNFSM6AAAAAAYWZDE7E> . You are receiving this because you were mentioned.Message ID: ***@***.***>

varadarajan-tw · 2023-07-19T06:46:26Z

Np. It is not mandatory to do this testing for the rollout.
If you have a Segment account, you can set up the walkme destination just like how customers would set up and test the change (Walkme docs). I can deploy this change specifically to your instance before rolling out to others so that you can test it and see if it looks okay.

The ID you shared looks doesn't look like a source ID. It would look something like this.

* [Walkme] Add option to choose a custom bucket (#759) * Add option to choose a custom bucket --------- Co-authored-by: Varadarajan V <109586712+varadarajan-tw@users.noreply.github.com> Co-authored-by: Varadarajan V <vvijayaragavan@twilio.com> * bump walkme integration version to 1.2.0 (#768) * fixes typo and related test (#771) * fixes typo and related test some test were returning false positive, update the way to check on them * bump package version to 1.2.1 --------- Co-authored-by: Varadarajan V <vvijayaragavan@twilio.com> * Support for SystemJS in MadKudu integration (#765) * UMD need window.require * Update version * STRATCONN-2841 added msgid as event id in propertyMap Added this property to test on stage branch * updating version * resolve conflit --------- Co-authored-by: paco-walkme <paco.g@walkme.com> Co-authored-by: Varadarajan V <109586712+varadarajan-tw@users.noreply.github.com> Co-authored-by: Varadarajan V <vvijayaragavan@twilio.com> Co-authored-by: Ghassen Rjab <rjab.ghassen@gmail.com>

* [Walkme] Add option to choose a custom bucket (#759) * Add option to choose a custom bucket --------- Co-authored-by: Varadarajan V <109586712+varadarajan-tw@users.noreply.github.com> Co-authored-by: Varadarajan V <vvijayaragavan@twilio.com> * bump walkme integration version to 1.2.0 (#768) * fixes typo and related test (#771) * fixes typo and related test some test were returning false positive, update the way to check on them * bump package version to 1.2.1 --------- Co-authored-by: Varadarajan V <vvijayaragavan@twilio.com> * Support for SystemJS in MadKudu integration (#765) * UMD need window.require * Update version * STRATCONN-2841 added msgid as event id in propertyMap Added this property to test on stage branch * updating version * resolve conflit * added console to track --------- Co-authored-by: paco-walkme <paco.g@walkme.com> Co-authored-by: Varadarajan V <109586712+varadarajan-tw@users.noreply.github.com> Co-authored-by: Varadarajan V <vvijayaragavan@twilio.com> Co-authored-by: Ghassen Rjab <rjab.ghassen@gmail.com>

* [Walkme] Add option to choose a custom bucket (#759) * Add option to choose a custom bucket --------- Co-authored-by: Varadarajan V <109586712+varadarajan-tw@users.noreply.github.com> Co-authored-by: Varadarajan V <vvijayaragavan@twilio.com> * bump walkme integration version to 1.2.0 (#768) * fixes typo and related test (#771) * fixes typo and related test some test were returning false positive, update the way to check on them * bump package version to 1.2.1 --------- Co-authored-by: Varadarajan V <vvijayaragavan@twilio.com> * Support for SystemJS in MadKudu integration (#765) * UMD need window.require * Update version * msg id and version updated * fixed walkme test case file --------- Co-authored-by: paco-walkme <paco.g@walkme.com> Co-authored-by: Varadarajan V <109586712+varadarajan-tw@users.noreply.github.com> Co-authored-by: Varadarajan V <vvijayaragavan@twilio.com> Co-authored-by: Ghassen Rjab <rjab.ghassen@gmail.com>

* [Walkme] Add option to choose a custom bucket (#759) * Add option to choose a custom bucket --------- Co-authored-by: Varadarajan V <109586712+varadarajan-tw@users.noreply.github.com> Co-authored-by: Varadarajan V <vvijayaragavan@twilio.com> * bump walkme integration version to 1.2.0 (#768) * fixes typo and related test (#771) * fixes typo and related test some test were returning false positive, update the way to check on them * bump package version to 1.2.1 --------- Co-authored-by: Varadarajan V <vvijayaragavan@twilio.com> * Support for SystemJS in MadKudu integration (#765) * UMD need window.require * Update version * msg id and version updated * fixed walkme test case file * msg id added in productPropertyMap --------- Co-authored-by: paco-walkme <paco.g@walkme.com> Co-authored-by: Varadarajan V <109586712+varadarajan-tw@users.noreply.github.com> Co-authored-by: Varadarajan V <vvijayaragavan@twilio.com> Co-authored-by: Ghassen Rjab <rjab.ghassen@gmail.com>

* [Walkme] Add option to choose a custom bucket (#759) * Add option to choose a custom bucket --------- Co-authored-by: Varadarajan V <109586712+varadarajan-tw@users.noreply.github.com> Co-authored-by: Varadarajan V <vvijayaragavan@twilio.com> * bump walkme integration version to 1.2.0 (#768) * fixes typo and related test (#771) * fixes typo and related test some test were returning false positive, update the way to check on them * bump package version to 1.2.1 --------- Co-authored-by: Varadarajan V <vvijayaragavan@twilio.com> * Support for SystemJS in MadKudu integration (#765) * UMD need window.require * Update version * msg id and version updated * fixed walkme test case file * msg id added in productPropertyMap * removed msgId from propertyMap --------- Co-authored-by: paco-walkme <paco.g@walkme.com> Co-authored-by: Varadarajan V <109586712+varadarajan-tw@users.noreply.github.com> Co-authored-by: Varadarajan V <vvijayaragavan@twilio.com> Co-authored-by: Ghassen Rjab <rjab.ghassen@gmail.com>

* [Walkme] Add option to choose a custom bucket (#759) * Add option to choose a custom bucket --------- Co-authored-by: Varadarajan V <109586712+varadarajan-tw@users.noreply.github.com> Co-authored-by: Varadarajan V <vvijayaragavan@twilio.com> * bump walkme integration version to 1.2.0 (#768) * fixes typo and related test (#771) * fixes typo and related test some test were returning false positive, update the way to check on them * bump package version to 1.2.1 --------- Co-authored-by: Varadarajan V <vvijayaragavan@twilio.com> * Support for SystemJS in MadKudu integration (#765) * UMD need window.require * Update version * msg id and version updated * fixed walkme test case file * msg id added in productPropertyMap * removed msgId from propertyMap * added logs in track and page events --------- Co-authored-by: paco-walkme <paco.g@walkme.com> Co-authored-by: Varadarajan V <109586712+varadarajan-tw@users.noreply.github.com> Co-authored-by: Varadarajan V <vvijayaragavan@twilio.com> Co-authored-by: Ghassen Rjab <rjab.ghassen@gmail.com>

paco-walkme added 3 commits June 1, 2023 13:27

Add option to choose a custom bucket

0116f93

fix typo

90d1366

forcing use the bucket option

42ad08e

but using `users` instead a custom name as we dont need to create a temporary directory on S3, the actual literal use is not important

paco-walkme closed this Jun 14, 2023

update literal to friendly name

2388376

paco-walkme reopened this Jun 14, 2023

varadarajan-tw reviewed Jul 4, 2023

View reviewed changes

integrations/walkme/lib/index.js Show resolved Hide resolved

paco-walkme and others added 2 commits July 5, 2023 15:29

fix typo

099020d

fix typo

168ebb0

varadarajan-tw self-requested a review July 5, 2023 13:34

varadarajan-tw approved these changes Jul 5, 2023

View reviewed changes

varadarajan-tw self-requested a review July 5, 2023 13:36

varadarajan-tw requested changes Jul 6, 2023

View reviewed changes

integrations/walkme/lib/index.js Outdated Show resolved Hide resolved

fix: dont use ES6

e9878ae

varadarajan-tw approved these changes Jul 17, 2023

View reviewed changes

varadarajan-tw mentioned this pull request Jul 17, 2023

[Walkme] Add bucket option #767

Closed

change customDirectory option name to customDirecotry as in partner p…

9f9f0f3

…ortal

varadarajan-tw merged commit e500f03 into segmentio:master Jul 18, 2023

varadarajan-tw mentioned this pull request Jul 18, 2023

[walkme] bump integration version to 1.2.0 #768

Merged

mattngan mentioned this pull request Jul 21, 2023

WalkMe integration broken for production environments #769

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Add option to choose a custom bucket #759

Add option to choose a custom bucket #759

Uh oh!

paco-walkme commented Jun 1, 2023 •

edited by varadarajan-tw

Loading

Uh oh!

varadarajan-tw left a comment •

edited

Loading

Uh oh!

Uh oh!

varadarajan-tw commented Jul 6, 2023

Uh oh!

Uh oh!

varadarajan-tw commented Jul 18, 2023

Uh oh!

varadarajan-tw commented Jul 19, 2023

Uh oh!

paco-walkme commented Jul 19, 2023 via email

Uh oh!

varadarajan-tw commented Jul 19, 2023

Uh oh!

Uh oh!

Add option to choose a custom bucket #759

Add option to choose a custom bucket #759

Uh oh!

Conversation

paco-walkme commented Jun 1, 2023 • edited by varadarajan-tw Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

varadarajan-tw left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

varadarajan-tw commented Jul 6, 2023

Uh oh!

Uh oh!

varadarajan-tw commented Jul 18, 2023

Uh oh!

varadarajan-tw commented Jul 19, 2023

Uh oh!

paco-walkme commented Jul 19, 2023 via email

Uh oh!

varadarajan-tw commented Jul 19, 2023

Uh oh!

Uh oh!

paco-walkme commented Jun 1, 2023 •

edited by varadarajan-tw

Loading

varadarajan-tw left a comment •

edited

Loading