fixes typo and related test #771
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
some test were returning false positive, update the way to check on them
|
Hey @paco-walkme, I initiated a revert of the previous PR change. We'll try to get this fix in this week. |
pooyaj
approved these changes
Jul 26, 2023
|
Hi Varadarajan,
We appreciate it a lot.
Thanks you and sorry for inconvenience caused.
Paco
…On Tue, 25 Jul 2023 at 06:45, Varadarajan V ***@***.***> wrote:
Hey @paco-walkme <https://github.com/paco-walkme>, I initiated a revert
of the previous PR change. We'll try to get this fix in this week.
—
Reply to this email directly, view it on GitHub
<#771 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ADUKDX4UWBL75BK3SSIWOWLXR5FPZANCNFSM6AAAAAA2UN5VBI>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
Np @paco-walkme ! I'll initiate the rollout again tomorrow. |
|
Hey @paco-walkme, the deployment is complete! |
|
Thank you so much for the support! Hopefully we don’t have any more trouble
to give.
Cheers
…On Thu, 3 Aug 2023 at 07:57, Varadarajan V ***@***.***> wrote:
Hey @paco-walkme <https://github.com/paco-walkme>, the deployment is
complete!
—
Reply to this email directly, view it on GitHub
<#771 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ADUKDX4VGBMOFXD2P4VXX7TXTM4TXANCNFSM6AAAAAA2UN5VBI>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
AnkitSegment
added a commit
that referenced
this pull request
Aug 4, 2023
* [Walkme] Add option to choose a custom bucket (#759) * Add option to choose a custom bucket --------- Co-authored-by: Varadarajan V <109586712+varadarajan-tw@users.noreply.github.com> Co-authored-by: Varadarajan V <vvijayaragavan@twilio.com> * bump walkme integration version to 1.2.0 (#768) * fixes typo and related test (#771) * fixes typo and related test some test were returning false positive, update the way to check on them * bump package version to 1.2.1 --------- Co-authored-by: Varadarajan V <vvijayaragavan@twilio.com> * Support for SystemJS in MadKudu integration (#765) * UMD need window.require * Update version * STRATCONN-2841 added msgid as event id in propertyMap Added this property to test on stage branch * updating version * resolve conflit --------- Co-authored-by: paco-walkme <paco.g@walkme.com> Co-authored-by: Varadarajan V <109586712+varadarajan-tw@users.noreply.github.com> Co-authored-by: Varadarajan V <vvijayaragavan@twilio.com> Co-authored-by: Ghassen Rjab <rjab.ghassen@gmail.com>
AnkitSegment
added a commit
that referenced
this pull request
Aug 4, 2023
* [Walkme] Add option to choose a custom bucket (#759) * Add option to choose a custom bucket --------- Co-authored-by: Varadarajan V <109586712+varadarajan-tw@users.noreply.github.com> Co-authored-by: Varadarajan V <vvijayaragavan@twilio.com> * bump walkme integration version to 1.2.0 (#768) * fixes typo and related test (#771) * fixes typo and related test some test were returning false positive, update the way to check on them * bump package version to 1.2.1 --------- Co-authored-by: Varadarajan V <vvijayaragavan@twilio.com> * Support for SystemJS in MadKudu integration (#765) * UMD need window.require * Update version * STRATCONN-2841 added msgid as event id in propertyMap Added this property to test on stage branch * updating version * resolve conflit * added console to track --------- Co-authored-by: paco-walkme <paco.g@walkme.com> Co-authored-by: Varadarajan V <109586712+varadarajan-tw@users.noreply.github.com> Co-authored-by: Varadarajan V <vvijayaragavan@twilio.com> Co-authored-by: Ghassen Rjab <rjab.ghassen@gmail.com>
AnkitSegment
added a commit
that referenced
this pull request
Aug 4, 2023
* [Walkme] Add option to choose a custom bucket (#759) * Add option to choose a custom bucket --------- Co-authored-by: Varadarajan V <109586712+varadarajan-tw@users.noreply.github.com> Co-authored-by: Varadarajan V <vvijayaragavan@twilio.com> * bump walkme integration version to 1.2.0 (#768) * fixes typo and related test (#771) * fixes typo and related test some test were returning false positive, update the way to check on them * bump package version to 1.2.1 --------- Co-authored-by: Varadarajan V <vvijayaragavan@twilio.com> * Support for SystemJS in MadKudu integration (#765) * UMD need window.require * Update version * msg id and version updated * fixed walkme test case file --------- Co-authored-by: paco-walkme <paco.g@walkme.com> Co-authored-by: Varadarajan V <109586712+varadarajan-tw@users.noreply.github.com> Co-authored-by: Varadarajan V <vvijayaragavan@twilio.com> Co-authored-by: Ghassen Rjab <rjab.ghassen@gmail.com>
AnkitSegment
added a commit
that referenced
this pull request
Aug 4, 2023
* [Walkme] Add option to choose a custom bucket (#759) * Add option to choose a custom bucket --------- Co-authored-by: Varadarajan V <109586712+varadarajan-tw@users.noreply.github.com> Co-authored-by: Varadarajan V <vvijayaragavan@twilio.com> * bump walkme integration version to 1.2.0 (#768) * fixes typo and related test (#771) * fixes typo and related test some test were returning false positive, update the way to check on them * bump package version to 1.2.1 --------- Co-authored-by: Varadarajan V <vvijayaragavan@twilio.com> * Support for SystemJS in MadKudu integration (#765) * UMD need window.require * Update version * msg id and version updated * fixed walkme test case file * msg id added in productPropertyMap --------- Co-authored-by: paco-walkme <paco.g@walkme.com> Co-authored-by: Varadarajan V <109586712+varadarajan-tw@users.noreply.github.com> Co-authored-by: Varadarajan V <vvijayaragavan@twilio.com> Co-authored-by: Ghassen Rjab <rjab.ghassen@gmail.com>
AnkitSegment
added a commit
that referenced
this pull request
Aug 7, 2023
* [Walkme] Add option to choose a custom bucket (#759) * Add option to choose a custom bucket --------- Co-authored-by: Varadarajan V <109586712+varadarajan-tw@users.noreply.github.com> Co-authored-by: Varadarajan V <vvijayaragavan@twilio.com> * bump walkme integration version to 1.2.0 (#768) * fixes typo and related test (#771) * fixes typo and related test some test were returning false positive, update the way to check on them * bump package version to 1.2.1 --------- Co-authored-by: Varadarajan V <vvijayaragavan@twilio.com> * Support for SystemJS in MadKudu integration (#765) * UMD need window.require * Update version * msg id and version updated * fixed walkme test case file * msg id added in productPropertyMap * removed msgId from propertyMap --------- Co-authored-by: paco-walkme <paco.g@walkme.com> Co-authored-by: Varadarajan V <109586712+varadarajan-tw@users.noreply.github.com> Co-authored-by: Varadarajan V <vvijayaragavan@twilio.com> Co-authored-by: Ghassen Rjab <rjab.ghassen@gmail.com>
AnkitSegment
added a commit
that referenced
this pull request
Aug 7, 2023
* [Walkme] Add option to choose a custom bucket (#759) * Add option to choose a custom bucket --------- Co-authored-by: Varadarajan V <109586712+varadarajan-tw@users.noreply.github.com> Co-authored-by: Varadarajan V <vvijayaragavan@twilio.com> * bump walkme integration version to 1.2.0 (#768) * fixes typo and related test (#771) * fixes typo and related test some test were returning false positive, update the way to check on them * bump package version to 1.2.1 --------- Co-authored-by: Varadarajan V <vvijayaragavan@twilio.com> * Support for SystemJS in MadKudu integration (#765) * UMD need window.require * Update version * msg id and version updated * fixed walkme test case file * msg id added in productPropertyMap * removed msgId from propertyMap * added logs in track and page events --------- Co-authored-by: paco-walkme <paco.g@walkme.com> Co-authored-by: Varadarajan V <109586712+varadarajan-tw@users.noreply.github.com> Co-authored-by: Varadarajan V <vvijayaragavan@twilio.com> Co-authored-by: Ghassen Rjab <rjab.ghassen@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
We have a typo of a missing / when calculating the URL of WalkMe.
Are there breaking changes in this PR?
no
Testing
Added extra test to specifically check that we are loading production proprely.
Fixed test giving false positives
Testing completed successfully in local via unit tests
Any background context you want to provide?
n/a
Is there parity with the server-side/android/iOS integration components (if applicable)?
n/a
Does this require a new integration setting? If so, please explain how the new setting works
n/a
Links to helpful docs and other external resources
n/a