Skip to content

Conversation

@ghost
Copy link

@ghost ghost commented Dec 13, 2024

Release

This would mean tagging c3c9bcd as v1.3.0-rc.2 to release.

Vote

We need at least 4 approvals from 6 maintainers to release notation-go v1.3.0-rc.2.

What's Changed

Full Changelog:
v1.3.0-rc.1...c3c9bcd

Actions

Please review the PR and vote by approving.

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
@codecov
Copy link

codecov bot commented Dec 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.97%. Comparing base (24baed8) to head (c3c9bcd).
Report is 2 commits behind head on release-1.3.

Additional details and impacted files
@@             Coverage Diff              @@
##           release-1.3     #495   +/-   ##
============================================
  Coverage        80.97%   80.97%           
============================================
  Files               34       34           
  Lines             3080     3080           
============================================
  Hits              2494     2494           
  Misses             455      455           
  Partials           131      131           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ghost
Copy link
Author

ghost commented Dec 13, 2024

LGTM

Copy link
Contributor

@JeyJeyGao JeyJeyGao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@vaninrao10 vaninrao10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ghost ghost merged commit 97ac273 into notaryproject:release-1.3 Dec 13, 2024
9 checks passed
@ghost ghost deleted the release-1.3 branch December 13, 2024 07:14
@ghost ghost mentioned this pull request Jan 15, 2025
6 tasks
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants