Skip to content

Conversation

@ghost
Copy link

@ghost ghost commented Dec 10, 2024

This PR targets on release-1.3 branch.

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
@codecov
Copy link

codecov bot commented Dec 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.88%. Comparing base (2d9fa22) to head (fbeccf3).
Report is 1 commits behind head on release-1.3.

Additional details and impacted files
@@             Coverage Diff              @@
##           release-1.3     #490   +/-   ##
============================================
  Coverage        80.88%   80.88%           
============================================
  Files               33       33           
  Lines             3066     3066           
============================================
  Hits              2480     2480           
  Misses             455      455           
  Partials           131      131           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JeyJeyGao
Copy link
Contributor

Should this PR be a cherry-pick of #488

@ghost
Copy link
Author

ghost commented Dec 10, 2024

Should this PR be a cherry-pick of #488

It doesn't have to be a cherry pick. In the previous cherry pick, I got a conflict for the bump up.

Copy link
Contributor

@JeyJeyGao JeyJeyGao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shizhMSFT shizhMSFT changed the title bump: bump up dependencies for release-1.3 branch bump: bump up notation-core-go for release-1.3 branch Dec 10, 2024
@shizhMSFT shizhMSFT changed the title bump: bump up notation-core-go for release-1.3 branch bump: bump up notation-core-go for release-1.3 branch Dec 10, 2024
Copy link

@vaninrao10 vaninrao10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ghost ghost merged commit 8aaebdd into notaryproject:release-1.3 Dec 11, 2024
9 checks passed
@ghost ghost deleted the release-1.3 branch December 11, 2024 00:17
@ghost ghost mentioned this pull request Dec 12, 2024
6 tasks
@ghost ghost mentioned this pull request Dec 13, 2024
6 tasks
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants