-
Notifications
You must be signed in to change notification settings - Fork 44
chore: backport #469 for updating logs #489
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-1.3 #489 +/- ##
===============================================
+ Coverage 80.60% 80.88% +0.28%
===============================================
Files 33 33
Lines 3062 3066 +4
===============================================
+ Hits 2468 2480 +12
+ Misses 463 455 -8
Partials 131 131 ☔ View full report in Codecov by Sentry. |
JeyJeyGao
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
JeyJeyGao
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
Referencing: |
shizhMSFT
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
vaninrao10
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This PR updates logs. Resolves #430. Also should resolve issue notaryproject/notation#1004. Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
This PR is for branch
release-1.3.