Skip to content

Conversation

@ghost
Copy link

@ghost ghost commented Dec 9, 2024

This PR is for branch release-1.3.

@codecov
Copy link

codecov bot commented Dec 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.88%. Comparing base (41d0380) to head (b3f528e).
Report is 1 commits behind head on release-1.3.

Additional details and impacted files
@@               Coverage Diff               @@
##           release-1.3     #489      +/-   ##
===============================================
+ Coverage        80.60%   80.88%   +0.28%     
===============================================
  Files               33       33              
  Lines             3062     3066       +4     
===============================================
+ Hits              2468     2480      +12     
+ Misses             463      455       -8     
  Partials           131      131              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@JeyJeyGao JeyJeyGao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ghost ghost requested a review from JeyJeyGao December 9, 2024 06:38
Copy link
Contributor

@JeyJeyGao JeyJeyGao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shizhMSFT
Copy link
Contributor

Referencing:

Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@vaninrao10 vaninrao10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

This PR updates logs.
Resolves #430. Also should resolve issue notaryproject/notation#1004.

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
@ghost ghost merged commit 2d9fa22 into notaryproject:release-1.3 Dec 10, 2024
9 checks passed
@ghost ghost deleted the backport branch December 10, 2024 00:38
This was referenced Dec 12, 2024
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants