-
Notifications
You must be signed in to change notification settings - Fork 0
Add flowchart manager for calculator example #4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting
| add_executable(headless_calculator | ||
| ${HEADLESS_CALC_SOURCE_FILES} | ||
| ${CALC_HEAEDR_FILES} | ||
| ${CALC_HEADER_FILES} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Avoid moc’ing FlowchartManager in headless target
The shared ${CALC_HEADER_FILES} list now contains FlowchartManager.hpp, which declares FlowchartManager and FlowchartPage with Q_OBJECT. Reusing that list for headless_calculator causes CMake’s automoc to generate meta-object code for those classes, but the target never builds FlowchartManager.cpp, so the moc object will reference undefined symbols such as FlowchartManager::addFlowchart() at link time. This breaks the headless example even though it never uses the flowchart manager. Consider either removing FlowchartManager.hpp from the header list or excluding it from the headless target to keep the build linking.
Useful? React with 👍 / 👎.
…charts Add execution controls for calculator flowcharts
修改CMakeLists.txt,将默认的USE_QT6选项设为OFF以使用Qt5,并添加C++17标准要求。同时更新Catch2下载配置,增加TLS验证关闭和超时设置。
…for-calculator-buttons Add manual execution control to calculator flowcharts
…d-issue Fix flowchart file handling
…t-save-and-load-issue-gcvabz
…d-issue-gcvabz Improve flowchart save/load workflow
…t-save-and-load-issue-5974lf
…ad-issue-5974lf Improve multi-flowchart save and load handling
…t-save-and-load-issue-l489wv
…ad-issue-l489wv Fix Windows build issues for flowchart manager
…t-save-and-load-issue-eg36j4
…ad-issue-eg36j4 Add project save/load workflow to calculator example
…t-save-and-load-issue-83s46s
…ad-issue-83s46s Fix calculator build issues on Windows
…t-save-and-load-issue-oco3km
…ad-issue-oco3km Rename FlowchartPage save helper for Windows build
…t-save-and-load-issue-za2tzd
…ad-issue-za2tzd Restore FlowchartPage::saveAs wrapper for compatibility
Summary
Testing
https://chatgpt.com/codex/tasks/task_e_68eda61890e4832d99c8d679f7caa1b2