Skip to content

Conversation

@legend-df
Copy link
Owner

Summary

  • remember the file chosen for each calculator flowchart and refresh the tab title after save/load
  • expose DataFlowGraphicsScene helpers to save and load from explicit file paths that can be reused by the UI

Testing

  • cmake -S . -B build (fails: missing Qt package and Catch2 download in CI environment)

https://chatgpt.com/codex/tasks/task_e_68edb5fb39ec832d8fffe84e1c68846f

@legend-df legend-df merged commit d970921 into codex/create-flowchart-manager Oct 14, 2025
Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting

Comment on lines +30 to +32
public:
bool saveToFile(QString const &fileName) const;
bool loadFromFile(QString const &fileName);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P0 Badge Include QString for new save/load API

The new saveToFile/loadFromFile declarations expose QString in the public header but the header does not include <QString> or forward‑declare the type. Any TU that includes this header without already including <QString> will now fail to compile. Add the missing include or a forward declaration so the interface is self‑contained.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants