Skip to content

Conversation

@legend-df
Copy link
Owner

Summary

  • add dedicated actions for saving the current flowchart, saving under a new name, and saving all tabs while centralising the save logic
  • reuse empty tabs when loading multiple flowcharts and keep the UI state in sync after successful loads or save attempts

Testing

  • cmake -S . -B build (fails: missing Qt package configuration and Catch2 download in the environment)

https://chatgpt.com/codex/tasks/task_e_68edb5fb39ec832d8fffe84e1c68846f

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting

Comment on lines +254 to +258
void FlowchartManager::saveCurrentFlowchartAs()
{
if (auto *page = currentPage()) {
bool const saved = saveFlowchart(page, /*forceSaveAs*/ true, /*showErrorOnFailure*/ false);
if (saved)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Suppressed error reporting when “Save Flowchart As…” fails

The new save‑as action intentionally forces saveFlowchart to run with showErrorOnFailure set to false. This means that if the user selects a path but the save actually fails (e.g. disk is full or the file is read‑only), the dialog closes silently and the user receives no warning that their changes were not written. Previously, the only save action surfaced failures. Hiding real save errors risks data loss; the action should either pass true here or detect cancelation separately so genuine failures can still be reported.

Useful? React with 👍 / 👎.

@legend-df legend-df merged commit 9edeb8c into codex/create-flowchart-manager Oct 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants