[ENG-1974] helper functions

[JadeCara]

Ticket ENG-1974

Description Of Changes

🎯 As a Fides user I want to be able to filter my results and then act on them, so that I can perform actions on many pages of results instead of having to go 1 by 1.

AC:

• Existing bulk action endpoints accept all the same filters as the search endpoint and apply the actions to the results.
• Existing bulk action endpoints accept a list of exclude_ids to be excluded from the actions
• Implementation reuses patterns for bulk actions used in the action center

This PR adds helper functions get the request ids from either a list or the filters being passed in. There is also a small re-organization of some functionality with the goal of providing better separation of concerns.

Code Changes

• src/fides/api/api/v1/endpoints/privacy_request_endpoints.py: adds the helper functions
• src/fides/service/privacy_request/privacy_request_filter_query_util.py
• src/fides/service/privacy_request/privacy_request_download_csv.py
• tests/serive/privacy_request/test_privacy_request_filter_query_utility.py tests the new helper functions

PRs in this chain:

• [ENG-1974] schema updates for bulk filtered dsr #7049 updates the schemas
• ENG-1974 add bulk operations to privacy request service #7050 updates the privacy request service to batch ids
• [ENG-1974] helper functions #7051 adds the helper functions for ids and filters
• [ENG-1974] Filtered bulk actions for DSRs #7027 updates the endpoints to use the filters with tests

Steps to Confirm

1. There should be no change in current functionality. Right now the front end passes back a list for all bulk functions so any tests with the front end should work exactly the same.

Pre-Merge Checklist

• Issue requirements met
• All CI pipelines succeeded
• CHANGELOG.md updated
  • Add a db-migration This indicates that a change includes a database migration label to the entry if your change includes a DB migration
  • Add a high-risk This issue suggests changes that have a high-probability of breaking existing code label to the entry if your change includes a high-risk change (i.e. potential for performance impact or unexpected regression) that should be flagged
  • Updates unreleased work already in Changelog, no new entry necessary
• UX feedback:
  • All UX related changes have been reviewed by a designer
  • No UX review needed
• Followup issues:
  • Followup issues created
  • No followup issues
• Database migrations:
  • Ensure that your downrev is up to date with the latest revision on main
  • Ensure that your downgrade() migration is correct and works
    • If a downgrade migration is not possible for this change, please call this out in the PR description!
  • No migrations
• Documentation:
  • Documentation complete, PR opened in fidesdocs
  • Documentation issue created in fidesdocs
  • If there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
  • No documentation updates required

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

2 Skipped Deployments

Project	Deployment	Preview	Comments	Updated (UTC)
fides-plus-nightly	Ignored	Preview		Dec 8, 2025 8:19pm
fides-privacy-center	Ignored			Dec 8, 2025 8:19pm

[codecov]

Codecov Report

❌ Patch coverage is 91.48936% with 16 lines in your changes missing coverage. Please review.
✅ Project coverage is 87.30%. Comparing base (366b798) to head (821e823).
⚠️ Report is 2 commits behind head on main.

Files with missing lines	Patch %	Lines
...ice/privacy_request/privacy_request_query_utils.py	88.17%	9 Missing and 2 partials ⚠️
.../api/api/v1/endpoints/privacy_request_endpoints.py	92.30%	1 Missing and 1 partial ⚠️
...ce/privacy_request/privacy_request_csv_download.py	96.42%	0 Missing and 2 partials ⚠️
...service/privacy_request/privacy_request_service.py	92.30%	1 Missing ⚠️

❌ Your patch status has failed because the patch coverage (91.48%) is below the target coverage (100.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #7051      +/-   ##
==========================================
+ Coverage   87.29%   87.30%   +0.01%     
==========================================
  Files         530      532       +2     
  Lines       34890    34936      +46     
  Branches     4046     4048       +2     
==========================================
+ Hits        30457    30502      +45     
- Misses       3551     3552       +1     
  Partials      882      882              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[greptile-apps]

Greptile Overview

Greptile Summary

Extracts privacy request filtering, sorting, and CSV download logic from endpoints into service layer utilities, following architectural best practices.

Major changes:

• Created privacy_request_query_utils.py with filter_privacy_request_queryset(), sort_privacy_request_queryset(), and resolve_request_ids_from_filters() helper functions
• Created privacy_request_csv_download.py to isolate CSV generation logic
• Added facade methods in PrivacyRequestService to provide clean API for endpoints
• Refactored endpoint functions to use service layer, removing ~400 lines of duplicated code
• Added comprehensive unit tests for new utility functions

The refactoring maintains backward compatibility and sets foundation for bulk filtered DSR actions in subsequent PRs.

Confidence Score: 5/5

• This PR is safe to merge - clean refactoring that extracts business logic to service layer with comprehensive test coverage
• Well-structured refactoring following established patterns, moving logic from endpoints to service layer. No functionality changes, only reorganization. Comprehensive unit tests verify helper functions work correctly.
• No files require special attention

Important Files Changed

File Analysis

Filename	Score	Overview
src/fides/service/privacy_request/privacy_request_query_utils.py	5/5	Extracted filtering, sorting, and ID resolution logic from endpoints into reusable utility functions - clean refactoring following the service layer pattern
src/fides/service/privacy_request/privacy_request_csv_download.py	5/5	Extracted CSV download logic from endpoints into dedicated module - clean separation of concerns
src/fides/service/privacy_request/privacy_request_service.py	5/5	Added facade methods to delegate to utility functions, providing a clean API for endpoints to use service layer
src/fides/api/api/v1/endpoints/privacy_request_endpoints.py	5/5	Refactored to use service layer instead of direct DB access, removing ~400 lines of duplicated filtering/sorting/CSV logic
tests/service/privacy_request/test_privacy_request_query_utility.py	5/5	Comprehensive unit tests for resolve_request_ids_from_filters covering explicit IDs, filters, exclusions, and edge cases

[greptile-apps]

_{2 files reviewed, 1 comment}

_{Edit Code Review Agent Settings | Greptile}

[JadeCara]

@greptile please review

[greptile-apps]

_{2 files reviewed, no comments}

_{Edit Code Review Agent Settings | Greptile}

[JadeCara]

@greptile please review

[greptile-apps]

_{7 files reviewed, no comments}

_{Edit Code Review Agent Settings | Greptile}

[erosselli]

Thanks for tackling the refactor!! ❤️

[erosselli]

I wonder if we can remove any of these or if they're still needed.... maybe one day we'll be able to remove them

[JadeCara]

Removed two of them!