-
Notifications
You must be signed in to change notification settings - Fork 84
ENG-1974 add bulk operations to privacy request service #7050
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7050 +/- ##
==========================================
+ Coverage 87.26% 87.29% +0.02%
==========================================
Files 530 530
Lines 34882 34890 +8
Branches 4044 4046 +2
==========================================
+ Hits 30440 30457 +17
+ Misses 3555 3551 -4
+ Partials 887 882 -5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Greptile OverviewGreptile SummaryUpdated privacy request service to automatically batch bulk operations when more than 50 requests are provided, removing the hard limit that previously required callers to handle batching.
Confidence Score: 5/5
Important Files ChangedFile Analysis
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
3 files reviewed, no comments
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
…-to-handle-bulk-ops
…-to-handle-bulk-ops
…-to-handle-bulk-ops
…-to-handle-bulk-ops
Co-authored-by: erosselli <67162025+erosselli@users.noreply.github.com>
…nto ENG-1974-be-schema-update
…-to-handle-bulk-ops
…-to-handle-bulk-ops
…-to-handle-bulk-ops
…-to-handle-bulk-ops
thabofletcher
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@JadeCara code LGTM and based on automated tests passing I'm going to approve - I haven't tested mysel, but the change is definitely an improvement
Ticket ENG-1974
Description Of Changes
🎯 As a Fides user I want to be able to filter my results and then act on them, so that I can perform actions on many pages of results instead of having to go 1 by 1.
AC:
This PR updates the privacy request service to batch ids when there are more than 50 (set as a constant in the schema)
Code Changes
src/fides/service/privacy_request/privacy_request_service.pyadds batching for bulk operationstests/ops/api/v1/endpoints/privacy_request/test_privacy_request_bulk_actions.pytests affected endpointstests/service/test_privacy_request_service.pytests for the service changePRs in this chain:
Steps to Confirm
Pre-Merge Checklist
CHANGELOG.mdupdatedmaindowngrade()migration is correct and works