[ENG-1974] schema updates for bulk filtered dsr #7049

JadeCara · 2025-12-01T18:40:54Z

Ticket ENG-1974

Description Of Changes

🎯 As a Fides user I want to be able to filter my results and then act on them, so that I can perform actions on many pages of results instead of having to go 1 by 1.

AC:

Existing bulk action endpoints accept all the same filters as the search endpoint and apply the actions to the results.
Existing bulk action endpoints accept a list of exclude_ids to be excluded from the actions
Implementation reuses patterns for bulk actions used in the action center

This PR updates the schema with tests and updates the endpoints with the schema. It paves the way for adding the filters to the request but the functionality will still currently only work with a list of ids.

Code Changes

src/fides/api/schemas/privacy_request.py: moved from ReviewPrivacyRequestIds to new PrivacyRequestBulkSelection schema for privacy request selection
src/fides/api/api/v1/endpoints/privacy_request_endpoints.py: Updated imports for new schemas functions with updates schema and functionality
bonus fix for some flaky tests erroring on teardown.

This is just the first step.

ENG-1974 add bulk operations to privacy request service #7050 updates the privacy request service to batch ids
[ENG-1974] helper functions #7051 adds the helper functions for ids and filters
[ENG-1974] Filtered bulk actions for DSRs #7027 updates the endpoints to use the filters with tests

Steps to Confirm

There should be no change in current functionality. Right now the front end passes back a list for all bulk functions so any tests with the front end should work exactly the same.

Pre-Merge Checklist

vercel · 2025-12-01T18:40:59Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Preview	Comments	Updated (UTC)
fides-plus-nightly	Ready	Preview	Comment	Dec 8, 2025 0:32am

1 Skipped Deployment

Project	Deployment	Preview	Comments	Updated (UTC)
fides-privacy-center	Ignored			Dec 8, 2025 0:32am

codecov · 2025-12-01T19:08:08Z

Codecov Report

❌ Patch coverage is 65.51724% with 10 lines in your changes missing coverage. Please review.
✅ Project coverage is 87.26%. Comparing base (04356c4) to head (805fd9d).
⚠️ Report is 8 commits behind head on main.

Files with missing lines	Patch %	Lines
.../api/api/v1/endpoints/privacy_request_endpoints.py	0.00%	5 Missing and 5 partials ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #7049      +/-   ##
==========================================
- Coverage   87.28%   87.26%   -0.02%     
==========================================
  Files         530      530              
  Lines       34858    34882      +24     
  Branches     4036     4044       +8     
==========================================
+ Hits        30426    30440      +14     
- Misses       3550     3555       +5     
- Partials      882      887       +5

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

greptile-apps · 2025-12-01T19:49:43Z

Greptile Overview

Greptile Summary

This PR refactors bulk privacy request action schemas to support future filtered operations. The changes replace ReviewPrivacyRequestIds with a new flexible PrivacyRequestBulkSelection schema that accepts either explicit IDs or filters (with exclusions).

Key changes:

Introduced PrivacyRequestBulkSelection with comprehensive validation ensuring request_ids and filters are mutually exclusive
Updated 5 bulk endpoints (approve, deny, cancel, finalize, soft-delete) with temporary guards requiring request_ids until filter support lands in subsequent PRs
Added schema unit tests covering all validation rules and edge cases
Fixed flaky performance tests by disabling celery worker during test teardown

The implementation follows good patterns with validation at the schema level rather than in route handlers. Current functionality remains unchanged as filter support is deferred to follow-up PRs #7050, #7051, and #7027.

Confidence Score: 5/5

This PR is safe to merge with minimal risk - it's a well-designed refactoring with comprehensive tests and no breaking changes
The changes are purely additive with no behavioral changes to existing functionality. The schema validation is thorough with clear error messages, comprehensive unit tests cover all edge cases, and the temporary guards in endpoints prevent premature use of filter functionality. The celery test fix addresses a legitimate flaky test issue.
No files require special attention

Important Files Changed

File Analysis

Filename	Score	Overview
src/fides/api/schemas/privacy_request.py	5/5	Replaced `ReviewPrivacyRequestIds` with new `PrivacyRequestBulkSelection` schema that supports both explicit IDs and filters. Added comprehensive validation logic with clear error messages for mutually exclusive options.
src/fides/api/api/v1/endpoints/privacy_request_endpoints.py	5/5	Updated 5 bulk action endpoints to use new schema with temporary guards requiring `request_ids` until filter support is added in subsequent PRs. Replaced assertions with proper HTTPException error handling.
tests/api/schemas/test_privacy_request.py	5/5	Added comprehensive unit tests for `PrivacyRequestBulkSelection` validation rules covering valid configurations and error cases with clear parametrized test cases.

greptile-apps

_{5 files reviewed, 5 comments}

_{Edit Code Review Agent Settings | Greptile}

src/fides/api/api/v1/endpoints/privacy_request_endpoints.py

Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>

JadeCara · 2025-12-01T21:04:50Z

@greptile please review

greptile-apps

_{5 files reviewed, no comments}

_{Edit Code Review Agent Settings | Greptile}

tests/ops/api/v1/endpoints/privacy_request/test_privacy_request_performance.py

erosselli

Approving with some nit comments

src/fides/api/schemas/privacy_request.py

erosselli · 2025-12-02T12:44:53Z

tests/api/schemas/test_privacy_request.py

+        "request_ids,filters,exclude_ids,expected_request_ids,expected_filters,expected_exclude_ids",
+        [
+            # Valid: explicit request_ids only
+            (
+                ["req-1", "req-2", "req-3"],
+                None,
+                None,
+                ["req-1", "req-2", "req-3"],
+                None,
+                None,


I'm a bit confused at this parameterization , it seems like expected_request_ids always matches request_ids , expected_filters always matches filters and expected_exclude_ids always matches exclude_ids . Are all the params needed?

erosselli · 2025-12-02T12:45:26Z

tests/api/schemas/test_privacy_request.py

+        assert selection.exclude_ids == expected_exclude_ids
+
+    @pytest.mark.parametrize(
+        "request_ids,filters,exclude_ids,expected_error_msg",


nit: another case would be just exclude ids provided

Ooo good point :D

added test :)

erosselli · 2025-12-02T12:46:15Z

tests/ops/api/v1/endpoints/privacy_request/test_privacy_request_performance.py

+@pytest.fixture(scope="session")
+def celery_use_virtual_worker():


This ended up not working :( updating the celery fixture to end if stuck instead.

Co-authored-by: erosselli <67162025+erosselli@users.noreply.github.com>

…nto ENG-1974-be-schema-update

schema updates for bulk filtered dsr

c1aa804

JadeCara mentioned this pull request Dec 1, 2025

[ENG-1974] Filtered bulk actions for DSRs #7027

Merged

18 tasks

JadeCara mentioned this pull request Dec 1, 2025

[ENG-1974] helper functions #7051

Merged

18 tasks

JadeCara marked this pull request as ready for review December 1, 2025 19:46

JadeCara requested a review from a team as a code owner December 1, 2025 19:46

JadeCara requested review from vcruces and removed request for a team December 1, 2025 19:46

JadeCara mentioned this pull request Dec 1, 2025

ENG-1974 add bulk operations to privacy request service #7050

Merged

18 tasks

greptile-apps bot reviewed Dec 1, 2025

View reviewed changes

JadeCara and others added 7 commits December 1, 2025 13:39

Update src/fides/api/api/v1/endpoints/privacy_request_endpoints.py

85c79e2

Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>

Update src/fides/api/api/v1/endpoints/privacy_request_endpoints.py

2eaa00c

Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>

Update src/fides/api/api/v1/endpoints/privacy_request_endpoints.py

dfa5004

Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>

Update src/fides/api/api/v1/endpoints/privacy_request_endpoints.py

19dedd9

Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>

Update src/fides/api/api/v1/endpoints/privacy_request_endpoints.py

706d244

Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>

linting

b1fafcf

linting

0dca99e

greptile-apps bot reviewed Dec 1, 2025

View reviewed changes

JadeCara changed the title ~~schema updates for bulk filtered dsr~~ [ENG-1974] schema updates for bulk filtered dsr Dec 1, 2025

JadeCara and others added 2 commits December 1, 2025 14:42

Merge branch 'main' into ENG-1974-be-schema-update

db732e0

.

dbb16ee

JadeCara commented Dec 1, 2025

View reviewed changes

tests/ops/api/v1/endpoints/privacy_request/test_privacy_request_performance.py Outdated Show resolved Hide resolved

Apply suggestion from @JadeCara

549a784

erosselli approved these changes Dec 2, 2025

View reviewed changes

JadeCara and others added 3 commits December 2, 2025 09:13

Update src/fides/api/schemas/privacy_request.py

35b5054

Co-authored-by: erosselli <67162025+erosselli@users.noreply.github.com>

include auto use to override other celery

d470fb8

Merge branch 'main' into ENG-1974-be-schema-update

93b06d3

vercel bot deployed to Preview – fides-plus-nightly December 2, 2025 17:58 View deployment

Jade Wibbels added 2 commits December 2, 2025 11:41

.

0b3e4ca

Merge branch 'ENG-1974-be-schema-update' of github.com:ethyca/fides i…

d24af89

…nto ENG-1974-be-schema-update

vercel bot deployed to Preview – fides-plus-nightly December 2, 2025 18:47 View deployment

Jade Wibbels and others added 4 commits December 2, 2025 12:27

updated tests

82f9b39

updated tests

c503182

.

da23cc7

Merge branch 'main' into ENG-1974-be-schema-update

805fd9d

vercel bot deployed to Preview – fides-plus-nightly December 8, 2025 12:32 View deployment

JadeCara enabled auto-merge December 8, 2025 12:53

JadeCara added this pull request to the merge queue Dec 8, 2025

Merged via the queue into main with commit 99a98fa Dec 8, 2025
68 of 69 checks passed

JadeCara deleted the ENG-1974-be-schema-update branch December 8, 2025 13:39

		@pytest.fixture(scope="session")
		def celery_use_virtual_worker():

[ENG-1974] schema updates for bulk filtered dsr #7049

[ENG-1974] schema updates for bulk filtered dsr #7049

Uh oh!

Conversation

JadeCara commented Dec 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description Of Changes

Code Changes

Steps to Confirm

Pre-Merge Checklist

Uh oh!

vercel bot commented Dec 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov bot commented Dec 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

greptile-apps bot commented Dec 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Greptile Overview

Greptile Summary

Confidence Score: 5/5

Important Files Changed

Uh oh!

greptile-apps bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

JadeCara commented Dec 1, 2025

Uh oh!

greptile-apps bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

erosselli left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

erosselli Dec 2, 2025

Choose a reason for hiding this comment

Uh oh!

JadeCara Dec 2, 2025

Choose a reason for hiding this comment

Uh oh!

erosselli Dec 2, 2025

Choose a reason for hiding this comment

Uh oh!

JadeCara Dec 2, 2025

Choose a reason for hiding this comment

Uh oh!

JadeCara Dec 2, 2025

Choose a reason for hiding this comment

Uh oh!

erosselli Dec 2, 2025

Choose a reason for hiding this comment

Uh oh!

JadeCara Dec 2, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

JadeCara commented Dec 1, 2025 •

edited

Loading

vercel bot commented Dec 1, 2025 •

edited

Loading

codecov bot commented Dec 1, 2025 •

edited

Loading

greptile-apps bot commented Dec 1, 2025 •

edited

Loading