Remove UIFeature.BulkUnverifiedSessionsReminder setting#31943
Merged
andybalaam merged 1 commit intodevelopfrom Feb 4, 2026
Merged
Remove UIFeature.BulkUnverifiedSessionsReminder setting#31943andybalaam merged 1 commit intodevelopfrom
andybalaam merged 1 commit intodevelopfrom
Conversation
andybalaam
added
T-Task
andybalaam
force-pushed
the
andybalaam/make-bulk-unverif-sessions-nonoptional
branch
from
ac1b77c to
7355037
Compare
Member
|
This was added by the PS team in 2022, presumably some customer may be using it, I'd expect this to need a deprecation period but will leave that decision to @element-hq/product |
Contributor
|
Thanks for flagging this. I'll handle the potential complaints, if any. We'd need to optimize for the crypto to work for majority of the users (by eliminating the complexity caused by edge cases). Additionally, given that unverified devices will stop receiving messages soon - there is no good reason to keep the unverified devices around. Thus, the suggestion is to remove them if you do not want to see the warning about them. |
Member
Author
|
We have Product approval from @mxandreas so this is ready for review. |
Member
Would be good if a tick was present |
mxandreas
approved these changes
Feb 4, 2026
Member
Author
Done |
t3chguy
approved these changes
Feb 4, 2026
andybalaam
deleted the
andybalaam/make-bulk-unverif-sessions-nonoptional
branch
alexlebens
pushed a commit
to alexlebens/infrastructure
that referenced
this pull request
Feb 24, 2026
This PR contains the following updates: | Package | Update | Change | |---|---|---| | [vectorim/element-web](https://github.com/element-hq/element-web) | patch | `v1.12.10` → `v1.12.11` | --- ### Release Notes <details> <summary>element-hq/element-web (vectorim/element-web)</summary> ### [`v1.12.11`](https://github.com/element-hq/element-web/releases/tag/v1.12.11) [Compare Source](element-hq/element-web@v1.12.10...v1.12.11) #### 🦖 Deprecations - Remove UIFeature.BulkUnverifiedSessionsReminder setting ([#​31943](element-hq/element-web#31943)). Contributed by [@​andybalaam](https://github.com/andybalaam). - Remove unused function to auto-rageshake when key backup is not set up ([#​31942](element-hq/element-web#31942)). Contributed by [@​andybalaam](https://github.com/andybalaam). #### ✨ Features - Room list: update the visuals in order to have better contrast ([#​32421](element-hq/element-web#32421)). Contributed by [@​florianduros](https://github.com/florianduros). - Set history visibility to "invited" for DMs and new non-public rooms when creating a room ([#​31974](element-hq/element-web#31974)). Contributed by [@​langleyd](https://github.com/langleyd). - Remove server acl status/summaries from timeline ([#​32461](element-hq/element-web#32461)). Contributed by [@​langleyd](https://github.com/langleyd). - Update `globalBlacklistUnverifiedDevices` on setting change ([#​31983](element-hq/element-web#31983)). Contributed by [@​kaylendog](https://github.com/kaylendog). - Add badge for history visibiltity to room info panel ([#​31927](element-hq/element-web#31927)). Contributed by [@​richvdh](https://github.com/richvdh). #### 🐛 Bug Fixes - Default useOnlyCurrentProfiles to true ([#​32524](element-hq/element-web#32524)). Contributed by [@​dbkr](https://github.com/dbkr). - Keep custom theme active after reload ([#​32506](element-hq/element-web#32506)). Contributed by [@​florianduros](https://github.com/florianduros). - Update font format from 'ttf' to 'truetype' ([#​32493](element-hq/element-web#32493)). Contributed by [@​all-yall](https://github.com/all-yall). - Fix videos on Firefox ([#​32497](element-hq/element-web#32497)). Contributed by [@​p1gp1g](https://github.com/p1gp1g). - Use a dedicated FAQ/help entry for key storage. ([#​32480](element-hq/element-web#32480)). Contributed by [@​mxandreas](https://github.com/mxandreas). - Avoid showing two chat timelines side by side after a call ([#​32484](element-hq/element-web#32484)). Contributed by [@​robintown](https://github.com/robintown). - Update screenshot for reactive display name disambiguation ([#​32431](element-hq/element-web#32431)). Contributed by [@​aditya-cherukuru](https://github.com/aditya-cherukuru). - Fix Status Bar being unreadable when the user overrides the default OS light/dark theme. ([#​32442](element-hq/element-web#32442)). Contributed by [@​Half-Shot](https://github.com/Half-Shot). - fix: Remove state\_key: null from Seshat search results ([#​31524](element-hq/element-web#31524)). Contributed by [@​shinaoka](https://github.com/shinaoka). - Fix user pill deserialisation ([#​31947](element-hq/element-web#31947)). Contributed by [@​t3chguy](https://github.com/t3chguy). </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0My4yNS43IiwidXBkYXRlZEluVmVyIjoiNDMuMjUuNyIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsiYXV0b21lcmdlIiwiaW1hZ2UiXX0=--> Reviewed-on: https://gitea.alexlebens.dev/alexlebens/infrastructure/pulls/4209 Co-authored-by: Renovate Bot <renovate-bot@alexlebens.net> Co-committed-by: Renovate Bot <renovate-bot@alexlebens.net>
alexlebens
pushed a commit
to alexlebens/infrastructure
that referenced
this pull request
Feb 24, 2026
…213) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [element-hq/element-web](https://github.com/element-hq/element-web) | patch | `v1.12.10` → `v1.12.11` | --- ### Release Notes <details> <summary>element-hq/element-web (element-hq/element-web)</summary> ### [`v1.12.11`](https://github.com/element-hq/element-web/releases/tag/v1.12.11) [Compare Source](element-hq/element-web@v1.12.10...v1.12.11) #### 🦖 Deprecations - Remove UIFeature.BulkUnverifiedSessionsReminder setting ([#​31943](element-hq/element-web#31943)). Contributed by [@​andybalaam](https://github.com/andybalaam). - Remove unused function to auto-rageshake when key backup is not set up ([#​31942](element-hq/element-web#31942)). Contributed by [@​andybalaam](https://github.com/andybalaam). #### ✨ Features - Room list: update the visuals in order to have better contrast ([#​32421](element-hq/element-web#32421)). Contributed by [@​florianduros](https://github.com/florianduros). - Set history visibility to "invited" for DMs and new non-public rooms when creating a room ([#​31974](element-hq/element-web#31974)). Contributed by [@​langleyd](https://github.com/langleyd). - Remove server acl status/summaries from timeline ([#​32461](element-hq/element-web#32461)). Contributed by [@​langleyd](https://github.com/langleyd). - Update `globalBlacklistUnverifiedDevices` on setting change ([#​31983](element-hq/element-web#31983)). Contributed by [@​kaylendog](https://github.com/kaylendog). - Add badge for history visibiltity to room info panel ([#​31927](element-hq/element-web#31927)). Contributed by [@​richvdh](https://github.com/richvdh). #### 🐛 Bug Fixes - Default useOnlyCurrentProfiles to true ([#​32524](element-hq/element-web#32524)). Contributed by [@​dbkr](https://github.com/dbkr). - Keep custom theme active after reload ([#​32506](element-hq/element-web#32506)). Contributed by [@​florianduros](https://github.com/florianduros). - Update font format from 'ttf' to 'truetype' ([#​32493](element-hq/element-web#32493)). Contributed by [@​all-yall](https://github.com/all-yall). - Fix videos on Firefox ([#​32497](element-hq/element-web#32497)). Contributed by [@​p1gp1g](https://github.com/p1gp1g). - Use a dedicated FAQ/help entry for key storage. ([#​32480](element-hq/element-web#32480)). Contributed by [@​mxandreas](https://github.com/mxandreas). - Avoid showing two chat timelines side by side after a call ([#​32484](element-hq/element-web#32484)). Contributed by [@​robintown](https://github.com/robintown). - Update screenshot for reactive display name disambiguation ([#​32431](element-hq/element-web#32431)). Contributed by [@​aditya-cherukuru](https://github.com/aditya-cherukuru). - Fix Status Bar being unreadable when the user overrides the default OS light/dark theme. ([#​32442](element-hq/element-web#32442)). Contributed by [@​Half-Shot](https://github.com/Half-Shot). - fix: Remove state\_key: null from Seshat search results ([#​31524](element-hq/element-web#31524)). Contributed by [@​shinaoka](https://github.com/shinaoka). - Fix user pill deserialisation ([#​31947](element-hq/element-web#31947)). Contributed by [@​t3chguy](https://github.com/t3chguy). </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0My4yNS43IiwidXBkYXRlZEluVmVyIjoiNDMuMjUuNyIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsiYXV0b21lcmdlIiwiaW1hZ2UiXX0=--> Reviewed-on: https://gitea.alexlebens.dev/alexlebens/infrastructure/pulls/4213 Co-authored-by: Renovate Bot <renovate-bot@alexlebens.net> Co-committed-by: Renovate Bot <renovate-bot@alexlebens.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the unused
UIFeature.BulkUnverifiedSessionsRemindersetting. It defaults to true, and since we already show individual toasts for new unverified devices, I can't think of a reason why we'd want to suppress the toast saying there are existing unverified devices.This change makes the reminder always appear if there are existing unverified devices, with no facility to turn it off via a setting.
Checklist
public/exportedsymbols have accurate TSDoc documentation.