Skip to content

Remove unused function to auto-rageshake when key backup is not set up#31942

Merged
andybalaam merged 1 commit intodevelopfrom
andybalaam/remove-automaticKeyBackNotEnabledReporting
Feb 3, 2026
Merged

Remove unused function to auto-rageshake when key backup is not set up#31942
andybalaam merged 1 commit intodevelopfrom
andybalaam/remove-automaticKeyBackNotEnabledReporting

Conversation

@andybalaam
Copy link
Member

@andybalaam andybalaam commented Feb 2, 2026

The setting automaticKeyBackNotEnabledReporting defaults to false and we are not aware of anyone using it. If turned on, it sends a rageshake whenever we detect that key backup (key storage) is turned off. This is not helpful, since it is perfectly valid for a user to turn key backup off.

Checklist

@andybalaam andybalaam marked this pull request as ready for review February 3, 2026 12:51
@andybalaam andybalaam requested a review from a team as a code owner February 3, 2026 12:51
@andybalaam andybalaam added this pull request to the merge queue Feb 3, 2026
@andybalaam andybalaam added T-Deprecation A pull request that makes something deprecated and removed T-Task Tasks for the team like planning labels Feb 3, 2026
Merged via the queue into develop with commit eb909f1 Feb 3, 2026
61 of 62 checks passed
@andybalaam andybalaam deleted the andybalaam/remove-automaticKeyBackNotEnabledReporting branch February 3, 2026 13:10
alexlebens pushed a commit to alexlebens/infrastructure that referenced this pull request Feb 24, 2026
This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [vectorim/element-web](https://github.com/element-hq/element-web) | patch | `v1.12.10` → `v1.12.11` |

---

### Release Notes

<details>
<summary>element-hq/element-web (vectorim/element-web)</summary>

### [`v1.12.11`](https://github.com/element-hq/element-web/releases/tag/v1.12.11)

[Compare Source](element-hq/element-web@v1.12.10...v1.12.11)

#### 🦖 Deprecations

- Remove UIFeature.BulkUnverifiedSessionsReminder setting ([#&#8203;31943](element-hq/element-web#31943)). Contributed by [@&#8203;andybalaam](https://github.com/andybalaam).
- Remove unused function to auto-rageshake when key backup is not set up ([#&#8203;31942](element-hq/element-web#31942)). Contributed by [@&#8203;andybalaam](https://github.com/andybalaam).

#### ✨ Features

- Room list: update the visuals in order to have better contrast ([#&#8203;32421](element-hq/element-web#32421)). Contributed by [@&#8203;florianduros](https://github.com/florianduros).
- Set history visibility to "invited" for DMs and new non-public rooms when creating a room ([#&#8203;31974](element-hq/element-web#31974)). Contributed by [@&#8203;langleyd](https://github.com/langleyd).
- Remove server acl status/summaries from timeline  ([#&#8203;32461](element-hq/element-web#32461)). Contributed by [@&#8203;langleyd](https://github.com/langleyd).
- Update `globalBlacklistUnverifiedDevices` on setting change ([#&#8203;31983](element-hq/element-web#31983)). Contributed by [@&#8203;kaylendog](https://github.com/kaylendog).
- Add badge for history visibiltity to room info panel ([#&#8203;31927](element-hq/element-web#31927)). Contributed by [@&#8203;richvdh](https://github.com/richvdh).

#### 🐛 Bug Fixes

- Default useOnlyCurrentProfiles to true ([#&#8203;32524](element-hq/element-web#32524)). Contributed by [@&#8203;dbkr](https://github.com/dbkr).
- Keep custom theme active after reload ([#&#8203;32506](element-hq/element-web#32506)). Contributed by [@&#8203;florianduros](https://github.com/florianduros).
- Update font format from 'ttf' to 'truetype' ([#&#8203;32493](element-hq/element-web#32493)). Contributed by [@&#8203;all-yall](https://github.com/all-yall).
- Fix videos on Firefox ([#&#8203;32497](element-hq/element-web#32497)). Contributed by [@&#8203;p1gp1g](https://github.com/p1gp1g).
- Use a dedicated FAQ/help entry for key storage. ([#&#8203;32480](element-hq/element-web#32480)). Contributed by [@&#8203;mxandreas](https://github.com/mxandreas).
- Avoid showing two chat timelines side by side after a call ([#&#8203;32484](element-hq/element-web#32484)). Contributed by [@&#8203;robintown](https://github.com/robintown).
- Update screenshot for reactive display name disambiguation ([#&#8203;32431](element-hq/element-web#32431)). Contributed by [@&#8203;aditya-cherukuru](https://github.com/aditya-cherukuru).
- Fix Status Bar being unreadable when the user overrides the default OS light/dark theme. ([#&#8203;32442](element-hq/element-web#32442)). Contributed by [@&#8203;Half-Shot](https://github.com/Half-Shot).
- fix: Remove state\_key: null from Seshat search results ([#&#8203;31524](element-hq/element-web#31524)). Contributed by [@&#8203;shinaoka](https://github.com/shinaoka).
- Fix user pill deserialisation ([#&#8203;31947](element-hq/element-web#31947)). Contributed by [@&#8203;t3chguy](https://github.com/t3chguy).

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0My4yNS43IiwidXBkYXRlZEluVmVyIjoiNDMuMjUuNyIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsiYXV0b21lcmdlIiwiaW1hZ2UiXX0=-->

Reviewed-on: https://gitea.alexlebens.dev/alexlebens/infrastructure/pulls/4209
Co-authored-by: Renovate Bot <renovate-bot@alexlebens.net>
Co-committed-by: Renovate Bot <renovate-bot@alexlebens.net>
alexlebens pushed a commit to alexlebens/infrastructure that referenced this pull request Feb 24, 2026
…213)

This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [element-hq/element-web](https://github.com/element-hq/element-web) | patch | `v1.12.10` → `v1.12.11` |

---

### Release Notes

<details>
<summary>element-hq/element-web (element-hq/element-web)</summary>

### [`v1.12.11`](https://github.com/element-hq/element-web/releases/tag/v1.12.11)

[Compare Source](element-hq/element-web@v1.12.10...v1.12.11)

#### 🦖 Deprecations

- Remove UIFeature.BulkUnverifiedSessionsReminder setting ([#&#8203;31943](element-hq/element-web#31943)). Contributed by [@&#8203;andybalaam](https://github.com/andybalaam).
- Remove unused function to auto-rageshake when key backup is not set up ([#&#8203;31942](element-hq/element-web#31942)). Contributed by [@&#8203;andybalaam](https://github.com/andybalaam).

#### ✨ Features

- Room list: update the visuals in order to have better contrast ([#&#8203;32421](element-hq/element-web#32421)). Contributed by [@&#8203;florianduros](https://github.com/florianduros).
- Set history visibility to "invited" for DMs and new non-public rooms when creating a room ([#&#8203;31974](element-hq/element-web#31974)). Contributed by [@&#8203;langleyd](https://github.com/langleyd).
- Remove server acl status/summaries from timeline  ([#&#8203;32461](element-hq/element-web#32461)). Contributed by [@&#8203;langleyd](https://github.com/langleyd).
- Update `globalBlacklistUnverifiedDevices` on setting change ([#&#8203;31983](element-hq/element-web#31983)). Contributed by [@&#8203;kaylendog](https://github.com/kaylendog).
- Add badge for history visibiltity to room info panel ([#&#8203;31927](element-hq/element-web#31927)). Contributed by [@&#8203;richvdh](https://github.com/richvdh).

#### 🐛 Bug Fixes

- Default useOnlyCurrentProfiles to true ([#&#8203;32524](element-hq/element-web#32524)). Contributed by [@&#8203;dbkr](https://github.com/dbkr).
- Keep custom theme active after reload ([#&#8203;32506](element-hq/element-web#32506)). Contributed by [@&#8203;florianduros](https://github.com/florianduros).
- Update font format from 'ttf' to 'truetype' ([#&#8203;32493](element-hq/element-web#32493)). Contributed by [@&#8203;all-yall](https://github.com/all-yall).
- Fix videos on Firefox ([#&#8203;32497](element-hq/element-web#32497)). Contributed by [@&#8203;p1gp1g](https://github.com/p1gp1g).
- Use a dedicated FAQ/help entry for key storage. ([#&#8203;32480](element-hq/element-web#32480)). Contributed by [@&#8203;mxandreas](https://github.com/mxandreas).
- Avoid showing two chat timelines side by side after a call ([#&#8203;32484](element-hq/element-web#32484)). Contributed by [@&#8203;robintown](https://github.com/robintown).
- Update screenshot for reactive display name disambiguation ([#&#8203;32431](element-hq/element-web#32431)). Contributed by [@&#8203;aditya-cherukuru](https://github.com/aditya-cherukuru).
- Fix Status Bar being unreadable when the user overrides the default OS light/dark theme. ([#&#8203;32442](element-hq/element-web#32442)). Contributed by [@&#8203;Half-Shot](https://github.com/Half-Shot).
- fix: Remove state\_key: null from Seshat search results ([#&#8203;31524](element-hq/element-web#31524)). Contributed by [@&#8203;shinaoka](https://github.com/shinaoka).
- Fix user pill deserialisation ([#&#8203;31947](element-hq/element-web#31947)). Contributed by [@&#8203;t3chguy](https://github.com/t3chguy).

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0My4yNS43IiwidXBkYXRlZEluVmVyIjoiNDMuMjUuNyIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsiYXV0b21lcmdlIiwiaW1hZ2UiXX0=-->

Reviewed-on: https://gitea.alexlebens.dev/alexlebens/infrastructure/pulls/4213
Co-authored-by: Renovate Bot <renovate-bot@alexlebens.net>
Co-committed-by: Renovate Bot <renovate-bot@alexlebens.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

T-Deprecation A pull request that makes something deprecated

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants