Plugin: Backport PHP changes for WordPress 6.2 release

[Mamaduka]

Related Trac ticket 57471.

This is the tracking issue to coordinate the backporting of all PHP changes added in the Gutenberg plugin that needs to be backported for the WordPress 6.2 release.

Files listed for WP 6.2

PRs that are strickenthrough are already merged in WordPress Core

lib

• class-wp-theme-json-gutenberg.php
  • Add a minHeight block support under dimensions #45300
  • Global styles: Allow indirect properties when unfiltered_html is not allowed #46388 | Trac ticket | Core PR
  • Global styles: add custom CSS panel to site editor #46141 | Trac ticket | Core PR
  • Global Styles: Allow content/wide widths when unfiltered_html is not allowed #46712 | Trac ticket | Core PR
  • Shadow: add shadow presets support via theme.json #46813 | Trac ticket | Core PR
  • Design Tools: Add a Position block support (including sticky), decoupled from layout #46142 | Trac ticket | Core PR
  • Edit block style variations from global styles #46343
  • Global Styles: Don't remove Custom CSS for users with the correct caps #47062 | Trac ticket | Core PR
  • Shadow: rename shadow palette to presets #47272 | Trac ticket | Core PR
  • Global Styles: Try per block custom CSS #46571
• class-wp-theme-json-resolver-gutenberg.php | Trac ticket | Core PR
• client-assets.php Might need a backport because of React 18 update.

lib/block-supports

• anchor.php
  • Add anchor support for dynamic blocks #44771 - @Soean Trac ticket | PR
• border.php
  • Minor code tweaks/optimizations (PHP) #43375 - @aristath
• colors.php
  • Minor code tweaks/optimizations (PHP) #43375 - @aristath
• dimensions.php
  • Add a minHeight block support under dimensions #45300 - @andrewserong Trac ticket | PR
• duotone.php
  • CS/QA: various minor fixes #44551 | Trac ticket | Commited ✅
  • Don't check if constants set by wp_initial_constants() are defined #45979 | Trac ticket | Commited ✅
    These are minor changes, and I (@Mamaduka) will backport them.
• elements.php
  • Update/block support settings use tag processor #46625 | Trac ticket | Commited ✅
• layout.php
  • Try adding layout classnames to inner block wrapper #44600 | Trac ticket | Core PR
  • Layout: ensure block content is always returned as a string after processing #45330 | Trac ticket | Core PR
  • Add Layout controls to children of Flex layout blocks #45364 | Trac ticket | Core PR
  • Layout child fixed size should not be fixed by default and should always have a value set #46139 | Trac ticket | Core PR
  • Update: Improve performance of gutenberg_render_layout_support_flag. #46074 | Trac ticket | Core PR
    @tellthemachines, @andrewserong, @jorgefilipecosta
• position.php
  • Design Tools: Add a Position block support (including sticky), decoupled from layout #46142 Requires WP_HTML_Tag_Processor
    @andrewserong | Trac Ticket | Core PR
• settings.php
  • Add: Frontend section presets output #42124 | Core PR
  • Update/block support settings use tag processor #46625 | Core PR
    @jorgefilipecosta, @dmsnell
• typography.php
  • Fluid typography: add configurable settings for minimum font size to theme.json #42489
    @ramonjd | Trac ticket | Core PR

lib/compat/wordpress-6.2

• block-patterns TBD
• block-editor-settings.php
  • Global styles: add custom CSS panel to site editor #46141
    @glendaviesnz | trac ticket | core PR
• block-patterns.php
  • Add: Template types to the patterns API. #45814
  • Patterns: Add new pattern categories #46144
  • Update: Move gutenberg_register_core_block_patterns from 6.1 to 6.2  #46249
  • [Patterns]: Update pattern category descriptions #46005
  • Update bundled patterns compat directory #45620 - No need to back port since we removed the bundled categories and we load them from PD [Patterns]: Remove bundled patterns #46450
  • Add block pattern categories' descriptions to the REST API and update the descriptions #45244
  • block_types from Pattern Directory | Trac ticket | Committed ✅ @ntsekouras
    @jorgefilipecosta, @ntsekouras, @Mamaduka, @youknowriad
• block-template-utils.php
  • Update: Remove need for template prefix in gutenberg_get_template_hierarchy. #46257
    @jorgefilipecosta
• blocks.php
  • Design Tools: Add a Position block support (including sticky), decoupled from layout #46142 @andrewserong | Trac ticket | Core PR |
• class-gutenberg-rest-block-pattern-categories-controller.php
  • Patterns: Fix PHP warning in categories REST API controller #45410
  • Add block pattern categories' descriptions to the REST API and update the descriptions #45244
    @Mamaduka, @youknowriad
• class-gutenberg-rest-block-patterns-controller-6-2.php
  • Add: Template types to the patterns API. #45814
  • Patterns: Add new pattern categories #46144
    @ntsekouras, @jorgefilipecosta
• class-gutenberg-rest-global-styles-controller-6-2.php
  • Global styles: add custom CSS panel to site editor #46141 | Trac Ticket | Core PR
  • Global Styles REST API endpoint: check custom CSS is included before attempting to validate #46561 | Trac Ticket | Core PR
  • Global Styles: Hide Custom CSS setting for users without 'edit_css' cap #46815 | Trac ticket | Core PR
    @glendaviesnz, @youknowriad, @Mamaduka
• class-gutenberg-rest-pattern-directory-controller-6-2.php
  • Pattern Directory API: Add support for pagination parameters #45293
  • [Pattern Directory]: Add categories endpoint #45749 (punted for 6.3)
    @ryelle, @ntsekouras
• default-filters.php
  • Add wp_theme_has_theme_json as a public API to know whether a theme has a theme.json #45168 @oandregal @hellofromtonya | Trac ticket | Committed ✅
  • Update wp_theme_has_theme_json to use WP_Object_Cache #45543
  • Global Styles: Update gutenberg_get_global_stylesheet to use WP_Object_Cache #45679
  • Merged data should consider origin to return early #45969
  • Make theme.json object caches non persistent #46150
    @oandregal, @mmtr @hellofromtonya | Trac ticket | Committed ✅
• edit-form-blocks.php
  • [Inserter]: Openverse integration #46251
    @ntsekouras
• get-global-styles-and-settings.php
  • Add wp_theme_has_theme_json as a public API to know whether a theme has a theme.json #45168 @oandregal @hellofromtonya | Trac ticket | Committed ✅
  • Update wp_theme_has_theme_json to use WP_Object_Cache #45543
  • Ignore cached wp_theme_has_theme_json when WP_DEBUG is enabled #45882 @oandregal @hellofromtonya | Trac ticket | Committed ✅
  • Global Styles: Update gutenberg_get_global_stylesheet to use WP_Object_Cache #45679
  • Update which origins are queried for gutenberg_get_global_settings #45971
  • Cleaner logic in wp_theme_has_theme_json #45950 @oandregal @hellofromtonya | Trac ticket | Committed ✅
  • Don't check if constants set by wp_initial_constants() are defined #45979
  • Make theme.json object caches non persistent #46150 @oandregal, @mmtr @hellofromtonya | Trac ticket | Committed ✅
  • Add WP_Object_Cache to the gutenberg_get_global_settings method #45372
  • Global styles: add custom CSS panel to site editor #46141 - @glendaviesnz | trac ticket | core PR
  • Global Styles: Add "custom-css" as an acceptable value in the docs for gutenberg_get_global_stylesheet #46493
  • Update PHPDoc for gutenberg_get_global_stylesheet #46817
  • Docs: Fix typos #46912
    The changes here are covered by wp_get_global_settings: add object cache wordpress-develop#3789. @oandregal, we might need to sync DocBlock fixes.
• rest-api.php
  • Add block pattern categories' descriptions to the REST API and update the descriptions #45244
  • Pattern Directory API: Add support for pagination parameters #45293
  • Patterns: Add new pattern categories #46144
  • Global styles: add custom CSS panel to site editor #46141 | trac ticket | core PR
  • Template Parts: Add an option to import widgets from the sidebars #45509 | Trac ticket | Core PR
  • REST API: Do not set sidebar status to 'active' when using classic theme #46966
    @Mamaduka, @youknowriad, @ryelle, @glendaviesnz, @ntsekouras
• script-loader.php
  • Use inert attribute instead of useDisabled #44865
  • Gallery: register styles with style engine #43070 | Trac ticket | Core PR (to land after JS packages update) | punted
  • Block editor: separate content styles for the iframe #44298
  • Fix fatal error by checking if block_type asset properties are set #46488 | No need to back port as it ensures back compat in GB.
  • Post editor: iframe for block-based themes #46212
  • Block Editor: Add inert polyfill to iframe #47398
    @youknowriad, @ramonjd, @ellatrix, @noahtallen, @t-hamano
• site-editor.php
  • Reorganize the site editor to introduce Browse Mode. #44770 | Core PR
    @youknowriad
• theme.php
  • Template Parts: Add an option to import widgets from the sidebars #45509 | Trac ticket | Core PR
    @Mamaduka
• widgets.php
  • Template Parts: Add an option to import widgets from the sidebars #45509 | Trac ticket | Core PR
    @Mamaduka

lib/experimental

HTML Tag Processor: @ockham, @dmsnell, @adamziel

• class-wp-html-attribute-token.php
• class-wp-html-span.php
• class-wp-html-tag-processor.php
• class-wp-html-text-replacement.php

Getting Involved

If you are interested in helping with the effort, you can comment (or edit the issue's description) with your name next to the file. It would also help to link to Track issues / GitHub PRs in WordPress core when they are available.

Action items when working on backports:

• Update the files to follow best practices. Mostly rename functions/classes to use the wp_ prefix instead of gutenberg_ and guard with declaration checks for code that needs to be backported to WordPress core.
• Identify files and functionality that need to be backported to WordPress core.
• Ensure all files, classes, methods, properties, and functions have the @since 6.2.0 documentation tag included.
• Ensure all functionality backported to WordPress core has unit tests written.

Issue modeled after #43440

[hellofromtonya]

Hey contributors 👋

I'd like to ask that each backport:

• be built in smaller PR increments, one thing in a PR
• open a new Core Trac ticket for each PR
• build backports as early as possible, i.e. when the thing to backport is ready to go into Core

Why?

• To ease the pain points and friction of backporting from GB to Core
• To help Core Committers with code reviews and commits
• To create a cleaner WP Core SVN commit history
• To help identify potential issues that may need a follow-up commit or revert
• To help identify what has and has not been backported, i.e. to hopefully reduce missed backports

[azaozz]

Like @hellofromtonya I think this method of "syncing" Gutenberg PHP changes to core Trac has proven to be hard to do and error prone. Instead each issue/PR that contains PHP changes and was merged to Gutenberg should be synced separately.

In that terms, thinking this issue should be closed and (maybe) replaced with an issue listing all PRs that contain PHP changes and were merged to Gutenberg. Then each of these PRs would get a corresponding Trac ticket (so there are no omissions) and linked to a patch/another PR where the PHP changes are being synced to https://github.com/WordPress/wordpress-develop.

A good start would be to identify all Gutenberg PRs that contain PHP changes to lib excluding the PRs that add changes to lib/experimental (these should be considered not ready for syncing). If changes from lib/experimental need to be synced to wordpress-develop, they should be moved out of the "experimental" code first, and ideally tested in a Gutenberg release.

[hellofromtonya]

Backport for wp_theme_has_theme_json() (which includes deprecating WP_Theme_JSON_Resolver::theme_has_support()):

• PR 3556 wp_theme_has_theme_json: add public method to know whether the theme supports theme.json wordpress-develop#3556
• Trac ticket 56975 https://core.trac.wordpress.org/ticket/56975

Update Jan 18, 2023:
This backport was committed today and Trac ticket closed ✅

[hellofromtonya]

(Web) Fonts API: I grouped those files together for tracking purposes and self-assigned.

Status: This API is still in development and is not yet ready to backport to Core.

[Mamaduka]

First of all, sorry for the mass ping.

I've updated the PR description with a detailed list¹ of PHP changes that need backporting to wordpress-develop in order to be included in WP 6.2. Each PR should get a corresponding Trac ticket and patch (or link to wordpress-develop PR).²

If you're unfamiliar with the process, feel free to ping me (@Mamaduka) or (@ntsekouras). We're happy to help!

Footnotes

1. PRs changing multiple files are listed multiple times, primarily for tracking purposes. ↩

2. See the comments from Tonya (https://github.com/WordPress/gutenberg/issues/47187#issuecomment-1384107056) and Andrew (https://github.com/WordPress/gutenberg/issues/47187#issuecomment-1384559863). ↩

[youknowriad]

FYI I'm working on the block patterns categories backports.

[aristath]

Thank you for the ping @Mamaduka!

border.php - #43375 - @aristath
colors.php - #43375 - @aristath

It appears the 1st change has already been applied to wp-trunk (https://github.com/WordPress/wordpress-develop/blob/0cb8475c0d07d23893b1d73d755eda5f12024585/src/wp-includes/block-supports/border.php#L19), and the 2nd one doesn't need to be backported (code is different on https://github.com/WordPress/wordpress-develop/blob/3dc123624556efbe8953c377e777c12c985ba339/src/wp-includes/block-supports/colors.php#L18 and the change doesn't seem to make sense there)

[andrewserong]

Thanks, I'm happy to work on backport PRs for all the ones I've been pinged on (and open up corresponding trac issues). From a quick skim, I think most of mine will depend on the HTML Tag Processor landing first.

I have a backport PR open for a bug fix that has already been approved, and is ready to land, if anyone gets a chance to take a look (I don't think it's listed here because it was a change to the theme JSON class):

• Global Styles: Fix block spacing values being stripped for users without unfiltered_html capability wordpress-develop#3742

[Mamaduka]

Thank you, @andrewserong!

@ockham, @dmsnell, @adamziel, what's the status on HTML Tag Processor? Is it ready for the core?

[ockham]

@ockham, @dmsnell, @adamziel, what's the status on HTML Tag Processor? Is it ready for the core?

I'll discuss with Dennis and Adam today!