Sync shadow presets support in theme.json#3915
Sync shadow presets support in theme.json#3915Mamaduka wants to merge 3 commits intoWordPress:trunkfrom
Conversation
Mamaduka
force-pushed
the
sync/shadow-presets-support
branch
from
45ac4fa to
8a12e9c
Compare
|
I just pushed the Cc @oandregal |
👍 Good call, those changes pertain to this feature as well. |
oandregal
left a comment
oandregal
left a comment
There was a problem hiding this comment.
Code changes look good, it has tests, and I verified that it works as expected following the test instructions at WordPress/gutenberg#46813
|
Current reviewing. There are a few tweaks needed to the tests. And there's a merge conflict. |
hellofromtonya
force-pushed
the
sync/shadow-presets-support
branch
from
fec0a49 to
020373c
Compare
|
Rebase this PR on top of |
| $this->assertEquals( $styles, $theme_json->get_stylesheet(), 'Returned of "::get_stylesheet" does not match expectations' ); | ||
| $this->assertEquals( $styles, $theme_json->get_stylesheet( array( 'variables' ) ), 'Returned of "::get_stylesheet" does not match expectations' ); |
There was a problem hiding this comment.
- use
assertSame() - Failure messages need to be different to identify which assertion failed.
Commit coming.
| $element_styles = 'a:where(:not(.wp-element-button)){box-shadow: var(--wp--preset--shadow--natural);}.wp-element-button, .wp-block-button__link{box-shadow: var(--wp--preset--shadow--natural);}p{box-shadow: var(--wp--preset--shadow--natural);}'; | ||
| $styles = $global_styles . $element_styles; | ||
|
|
||
| $this->assertEquals( $styles, $theme_json->get_stylesheet() ); |
There was a problem hiding this comment.
- use
assertSame()
Commit coming.
hellofromtonya
left a comment
hellofromtonya
left a comment
There was a problem hiding this comment.
- Confirmed both GB PRs are present in this PR ✅
- Changes are noted in
@since 6.2.0✅ - Includes tests ✅
- Has a test report ✅
Ready for commit.
|
Committed via https://core.trac.wordpress.org/changeset/55176. |
3 participants
Trac ticket: https://core.trac.wordpress.org/ticket/57559
Gutenberg PRs: