Backport: Duotone code quality fixes#3890
Closed
Mamaduka wants to merge 2 commits intoWordPress:trunkfrom
Closed
Conversation
Mamaduka
changed the title
Member
Author
85 tasks
hellofromtonya
approved these changes
Jan 25, 2023
Contributor
hellofromtonya
left a comment
hellofromtonya
left a comment
There was a problem hiding this comment.
Confirmed: all code quality changes from the 2 GB PRs are included in this PR. Each is likely worthy of a separate atomic commit for commit history. Why? Each is a different improvement with its own context information of why the change is being made.
I'll prep and do the commits.
Contributor
|
Both atomic commits where committed via changesets https://core.trac.wordpress.org/changeset/55140 and https://core.trac.wordpress.org/changeset/55140. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trac ticket: https://core.trac.wordpress.org/ticket/57527
Related Gutenberg PR:
wp_initial_constants()are defined gutenberg#45979Props @jrfnl, @ocean90
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.