Conversation
Documentation update (solver + OutListParameters)
Feature/update if w hawc
added some quotation marks in case of spaces in path names added "call" to command line
- remove unused code - update text formatting - add version header file to vs-build - fix some error handling in OpenFOAM.f90
… FVW needs more work
Now it is consistent between gfortran and ifort compilers.
Add RANLUX to NWTC Library / HydroDyn
OpenFAST currently uses `DOUBLE_PRECISION` compile-time definition to activate double precision as default during build. This conflicts with the define in the MPI header file (for HPE MPT) when building the C++ API interface. This commit works around this issue by using `OPENFAST_DOUBLE_PRECISION` variable when building with CMake. The code checks for the original `DOUBLE_PRECISION` macro for backward compatibility. The VS build pathway is unaffected. Fixes #522
* Add error check in FAST_OpFM_Init * Deallocate Turbine object and let calling routine do the error handling
ebranlard
approved these changes
Sep 14, 2020
Contributor
ebranlard
left a comment
ebranlard
left a comment
There was a problem hiding this comment.
It's nice to have all these links to the documentation! (they are broken now, but from what I've seen they should point to the right location after the merge).
I checked the API changes in the doc, and I believe they are all there.
andrew-platt
approved these changes
Sep 14, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Complete this sentence
THIS PULL REQUEST IS READY TO MERGE
Feature or improvement description
This pull request merges dev into master for a tagged release, v2.4.0. See below for the proposed change log.
Related issue, if one exists
None
Impacted areas of the software
See the proposed change log below.
Test results, if applicable
The baseline results have changed since the last release. See the r-test pull requests for more information.
General
openfast -vandopenfast -h)AeroDyn
BeamDyn
ElastoDyn
ExtPtfm
InflowWind
ServoDyn
r-test