Workaround DOUBLE_PRECISION macro when building with HPE MPT#524
Merged
rafmudaf merged 1 commit intoOpenFAST:devfrom Aug 13, 2020
Merged
Workaround DOUBLE_PRECISION macro when building with HPE MPT#524rafmudaf merged 1 commit intoOpenFAST:devfrom
rafmudaf merged 1 commit intoOpenFAST:devfrom
Conversation
OpenFAST currently uses `DOUBLE_PRECISION` compile-time definition to activate double precision as default during build. This conflicts with the define in the MPI header file (for HPE MPT) when building the C++ API interface. This commit works around this issue by using `OPENFAST_DOUBLE_PRECISION` variable when building with CMake. The code checks for the original `DOUBLE_PRECISION` macro for backward compatibility. The VS build pathway is unaffected. Fixes OpenFAST#522
Contributor
Author
|
FYI @jrood-nrel |
Collaborator
|
Excellent. Thanks for doing this. |
andrew-platt
approved these changes
Aug 13, 2020
bjonkman
added a commit
to bjonkman/openfast
that referenced
this pull request
May 8, 2023
…SION` This backward-compatibility of preprocessor definitions from OpenFAST#524 was broken in OpenFAST#1453.
deslaughter
pushed a commit
to deslaughter/openfast
that referenced
this pull request
May 8, 2023
…SION` This backward-compatibility of preprocessor definitions from OpenFAST#524 was broken in OpenFAST#1453.
deslaughter
added a commit
to deslaughter/openfast
that referenced
this pull request
May 8, 2023
…SION` This backward-compatibility of preprocessor definitions from OpenFAST#524 was broken in OpenFAST#1453.
deslaughter
added a commit
to deslaughter/openfast
that referenced
this pull request
May 8, 2023
This backward-compatibility of preprocessor definitions from OpenFAST#524 was broken in OpenFAST#1453.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OpenFAST currently uses
DOUBLE_PRECISIONcompile-time definition to activate double precision as default during build. This conflicts with the define in the MPI header file (for HPE MPT) when building the C++ API interface. This commit works around this issue by usingOPENFAST_DOUBLE_PRECISIONvariable when building with CMake. The code checks for the originalDOUBLE_PRECISIONmacro for backward compatibility. The VS build pathway is unaffected.Fixes #522
THIS PULL REQUEST IS READY TO MERGE
Impacted areas of the software
NWTC_Library