Fix issue in ServoDyn yaw position integration#460
Merged
andrew-platt merged 1 commit intoOpenFAST:devfrom Jun 9, 2020
Merged
Conversation
This would have been noticed if a simulation was controlling yaw from the Bladed-style DLL and then overriding it with a yaw maneuver. The initial yaw position for the maneuver would be calculated incorrectly (one step off).
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
THIS PULL REQUEST IS READY TO MERGE
Feature or improvement description
This is a follow up to #456. It fixes an issue in updating the states when a yaw maneuver is beginning.
Impacted areas of the software
This could have been noticed when a simulation was controlling yaw from the Bladed-style DLL and then overriding it with a yaw maneuver. The initial yaw position for the maneuver would be calculated incorrectly because the integration would occur twice.