-
Notifications
You must be signed in to change notification settings - Fork 47
Support for Double Sided Key and Multiple New Key Formats #20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Continued work needed to check other keys like s22.
|
God damn! That's a lot of car keys. This could benefit from this since you wouldn't want the bottom horizontal line in the way for double sided keys. I will make a few adjustments for some format's clearnace, e.g. RU45 should have a clearance of 5 instead of 8. In the mean time, this format has some weird graphics that I'm not sure what caused it. |
|
I've fixed the issue. Lowered it to 6 pin, which is fine, and moved first pin spacing to the right and matched the last pin inch with the added space. |
|
You should keep an eye on my saved files that go with the program. It makes a lot better to understand what I've been doing. |
|
Yes I see that you included the data sheets and manufacturer. Very impressive work! I'm not sure if OFW team would like us to show brands names explicitly in the user interface but having it in the saved file should be fine. |
|
fixed y2. Sorry. I knew there was a few last bugs to work out. |
|
No it's all good. Bugs happen all the time. Your last Y2 fix commit reverted some clearance fix I made. You might wanna pull the PR branch to stay updated before adding new changes on top of it. But no need to do that this time--I will resolve the conflicts. |
This reverts commit 6f28815.
|
Looks good to me! |


No description provided.