Honest locksmith

[HonestLocksmith]

Added double sided key logic and additional keys.

[zinongli]

Hi, I'm sorry for the late reply. It's been a few busy and draining month with work and family for me. My apologies.

I just built the app and tried it. I'm really thankful for your work. If I'm understanding correctly, you added several formats, and added logic for handling double-sided keys. If I missed anything please let me know. I'm a bit rusty with my own code after these few months.

For the added formats, most of them are great. Works right out of the box. There are some graphic issue with formats that have drill angles that aren't 90 degrees. Those would have to be manually tuned or just coarsely simulated with 90 degrees. We are limited by the pixel-per-inch of the Flipper's screen here. See here for some examples of this issue:

AR4 is 105 deg and S22 is 80 deg. In fact Schalge is 100 but I reverted to 90 after seeing how ugly it could get. The main issue is the place where one line meets another, there would be protruding lints. I don't have an immidieate resolution, other than mapping and adjusting each combination of neighboring bittings manually. My expectation is the algorithm that can handle this might have a similar size as storing images directly, as there might not be a lot of compressable information. And we would need that for each format, or at least each drill angle.

The double sided Ford key looks nice. I'm not sure why you didn't choose to draw the contours for the lower side. But right now it's a great proof of concept. If you like I can implement the other side.

Also, why was there a vertical line at the left side of the screen? I looked through the line it was introduced but didn't find a comment. Was it for alignment?

[zinongli]

I think I will merge the new formats that are 90 deg drill angles. The werid angled ones and the double-sided one need more work before put into release. Also I will omit the vertical line for now. But let me know what it's for and maybe we will have it. Again, thanks for doing this. It means a lot.

[HonestLocksmith]

I think I will merge the new formats that are 90 deg drill angles. The werid angled ones and the double-sided one need more work before put into release. Also I will omit the vertical line for now. But let me know what it's for and maybe we will have it. Again, thanks for doing this. It means a lot.

By all means, fix whatever you think would help. I may have missed a few things. Yes, I've added and fixed a number or issue with the key formats. I think i have a final version, except for that missing contour.

[HonestLocksmith]

Also, why was there a vertical line at the left side of the screen? I looked through the line it was introduced but didn't find a comment. Was it for alignment?

I've moved it to the correct position to the right. It's a tip stop. If in formats tip = 2 is in the key format information it draws the correct line at location lengs of the first pin inch after the last. Some double side keys use it, some dont, hence it's it's owm format.
Certain keys are

[HonestLocksmith]

I think I will merge the new formats that are 90 deg drill angles. The werid angled ones and the double-sided one need more work before put into release. Also I will omit the vertical line for now. But let me know what it's for and maybe we will have it. Again, thanks for doing this. It means a lot.

Yes, 90 is fine. That information isn't important to the measurements, but the draw. I've been playing with it to simulate laser cut keys. Please see my new PR, that line is important.

[zinongli]

Also, why was there a vertical line at the left side of the screen? I looked through the line it was introduced but didn't find a comment. Was it for alignment?

I've moved it to the correct position to the right. It's a tip stop. If in formats tip = 2 is in the key format information it draws the correct line at location lengs of the first pin inch after the last. Some double side keys use it, some dont, hence it's it's owm format. Certain keys are

I see you idea now. Then I think it should be on x = 0 instead of x = 1 (in C it counts from 0 and all the other values are calculated assuming this). And just for aesthetics I prefer to have it only protruding upwards for a few pixels, like this:

[zinongli]

Duplicate and replaced by #20

[HonestLocksmith]

Sorry. I had to fix sfic again anyways.

[HonestLocksmith]

Sfic was definitely not supposed to be a double sided key