Skip to content

Tests: Improve Windows compatibility #249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
swissspidy merged 3 commits into from
Apr 10, 2026
+3 −2
Merged

Tests: Improve Windows compatibility #249

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
aae87d8
Tests: Improve Windows compatibility
swissspidy Apr 10, 2026
d8b3c14
Update features/media-import.feature
swissspidy Apr 10, 2026
afd557a
use php
swissspidy Apr 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion features/media-import.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -325,7 +325,8 @@ Feature: Manage WordPress attachments
my-image.png.png
"""
Scenario: Fail to import from STDIN when no input provided
When I try `wp media import - </dev/null`
When I run `php -r "file_put_contents('empty.txt', '');"`
And I try `wp media import - < empty.txt`
Then STDERR should contain:
"""
Warning: Unable to import file from STDIN. Reason: No input provided.
Expand Down
2 changes: 1 addition & 1 deletion src/Media_Command.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -571,7 +571,7 @@ public function import( $args, $assoc_args = array() ) {
}

// Determine file extension from content
$mimetype = mime_content_type( $tempfile );
$mimetype = function_exists( 'mime_content_type' ) ? mime_content_type( $tempfile ) : '';

// Map MIME type to extension
$ext = '';
Expand Down