Skip to content

Tests: Improve Windows compatibility#249

Merged
swissspidy merged 3 commits intomainfrom
fix/windows-tests
Apr 10, 2026
Merged

Tests: Improve Windows compatibility#249
swissspidy merged 3 commits intomainfrom
fix/windows-tests

Conversation

@swissspidy
Copy link
Copy Markdown
Member

No description provided.

@swissspidy swissspidy requested a review from a team as a code owner April 10, 2026 07:59
Copilot AI review requested due to automatic review settings April 10, 2026 07:59
@github-actions
Copy link
Copy Markdown
Contributor

Hello! 👋

Thanks for opening this pull request! Please check out our contributing guidelines. We appreciate you taking the initiative to contribute to this project.

Contributing isn't limited to just code. We encourage you to contribute in the way that best fits your abilities, by writing tutorials, giving a demo at your local meetup, helping other users with their support questions, or revising our documentation.

Here are some useful Composer commands to get you started:

  • composer install: Install dependencies.
  • composer test: Run the full test suite.
  • composer phpcs: Check for code style violations.
  • composer phpcbf: Automatically fix code style violations.
  • composer phpunit: Run unit tests.
  • composer behat: Run behavior-driven tests.

To run a single Behat test, you can use the following command:

# Run all tests in a single file
composer behat features/some-feature.feature

# Run only a specific scenario (where 123 is the line number of the "Scenario:" title)
composer behat features/some-feature.feature:123

You can find a list of all available Behat steps in our handbook.

@github-actions github-actions bot added the scope:testing Related to testing label Apr 10, 2026
@swissspidy swissspidy added this to the 2.2.7 milestone Apr 10, 2026
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the media import test to use an empty file for STDIN simulation and adds a check for the mime_content_type function to prevent fatal errors when the fileinfo extension is missing. Feedback suggests that simply defaulting to an empty string when the function is unavailable will still cause import failures due to missing file extensions; therefore, a fallback mechanism using getimagesize() is recommended to improve robustness.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR aims to improve Windows compatibility for the media import workflow/tests by avoiding platform-specific assumptions and by hardening STDIN import MIME detection against missing PHP functions.

Changes:

  • Guard mime_content_type() usage during STDIN imports to avoid fatal errors when the function is unavailable.
  • Update the Behat scenario for “no STDIN input provided” to avoid using /dev/null.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
src/Media_Command.php Adds a safe fallback when mime_content_type() is not available during STDIN imports.
features/media-import.feature Adjusts the STDIN “no input” test to use an empty file instead of /dev/null.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 10, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

swissspidy and others added 2 commits April 10, 2026 10:09
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@swissspidy swissspidy merged commit f5524dc into main Apr 10, 2026
62 checks passed
@swissspidy swissspidy deleted the fix/windows-tests branch April 10, 2026 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

scope:testing Related to testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants