Skip to content

Conversation

@gsheni
Copy link
Collaborator

@gsheni gsheni commented Jun 16, 2025

@gsheni gsheni self-assigned this Jun 16, 2025
@codecov
Copy link

codecov bot commented Jun 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.14%. Comparing base (725688f) to head (6e38d15).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #479   +/-   ##
=======================================
  Coverage   90.14%   90.14%           
=======================================
  Files          29       29           
  Lines        1826     1826           
=======================================
  Hits         1646     1646           
  Misses        180      180           
Flag Coverage Δ
integration 79.73% <100.00%> (ø)
unit 86.85% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Collaborator

@amontanez24 amontanez24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I forgot to mention this but you will have to update the make release command because it creates the tag automatically and we said that we would create the tag on github when publishing the release. We should also update the release notes to match this

RELEASE.md Outdated
### Update the release on GitHub

Once the tag and the release to PyPi has been made, go to GitHub and edit the freshly created "tag" to
Once the tag and the release to PyPI has been made, go to GitHub and edit the freshly created "tag" to
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tag would not have been made yet in this case. The releaser will need to create the tag through the UI

@gsheni gsheni marked this pull request as draft June 20, 2025 16:58
@gsheni gsheni marked this pull request as ready for review June 20, 2025 18:09
@gsheni gsheni requested a review from amontanez24 June 20, 2025 18:19
Co-authored-by: Roy Wedge <roy.wedge@gmail.com>
@gsheni gsheni merged commit 4c4a93e into main Jun 20, 2025
77 checks passed
@gsheni gsheni deleted the 478-copulas-release-workflow-errors-with-failed-to-push-some-refs-to-httpsgithubcomsdv-devcopulas branch June 20, 2025 23:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Copulas release workflow errors with failed to push some refs to https://github.com/sdv-dev/Copulas

5 participants