-
Notifications
You must be signed in to change notification settings - Fork 118
Closed
Labels
bugThere is an error in the code that needs to be fixedThere is an error in the code that needs to be fixedinternalThe issue doesn't change the API or functionalityThe issue doesn't change the API or functionality
Milestone
Description
Environment Details
Please indicate the following details about the environment in which you found the bug:
- Copulas version: 0.12.3
Error Description
The release workflow is failing when release candidate is enabled. This is because it attempts to push directly to main but is stopped by the branch protection rules.
Steps to reproduce
- Run the workflow with release candidate enabled
Additional context
- Instead of merging directly we should open a PR and enable automerge either using this action or GitHub cli as described in that action's GitHub page.
- Another issue is that the release workflow was not triggered when the release was published on GitHub. It should according to the workflow configuration
Copulas/.github/workflows/release.yml
Lines 3 to 5 in 725688f
on: release: types: [published] - But you can see in the release workflow history that the only workflows kicked off on June 13 were manually triggered, but a release was published that day. We should fix that.
Metadata
Metadata
Assignees
Labels
bugThere is an error in the code that needs to be fixedThere is an error in the code that needs to be fixedinternalThe issue doesn't change the API or functionalityThe issue doesn't change the API or functionality