Conversation
agourlay
force-pushed
the
retry-after-header-grpc
branch
from
e4055bf to
f550fa6
Compare
agourlay
commented
Feb 27, 2025
| } = retry_error; | ||
| let description = format!( | ||
| "{rate_limiter_type} rate limit exceeded: Operation requires {cost} tokens but only {tokens_available} were available. Retry after {}s", | ||
| "{rate_limiter_type} rate limit exceeded: Operation requires {cost} tokens but only {tokens_available:.1} were available. Retry after {}s", |
Member
Author
There was a problem hiding this comment.
no need to display more than one digit precision
timvisee
approved these changes
Feb 28, 2025
Co-authored-by: Tim Visée <tim+github@visee.me>
This was referenced Mar 4, 2025
This was referenced Mar 19, 2025
timvisee
added a commit
that referenced
this pull request
Mar 21, 2025
* Add retry-after header for gRPC * propagate retry-after within inter node communication * snipe * tweak and test * log all parsing errors * Update lib/collection/src/operations/types.rs Co-authored-by: Tim Visée <tim+github@visee.me> --------- Co-authored-by: Tim Visée <tim+github@visee.me>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up to #5917 for the gRPC API.
The
retry-afterheader is passed using the standard gRPC metadata structure.The value can easily be extracted my clients. (e.g. Rust client)
This PR makes sure that the
retry-afterheader is properly propagated during inter node communication.There is a test to validate the end to end error propagation when querying an empty node.