Fix "Wheel naming is not following PEP 491 convention"#4766
Fix "Wheel naming is not following PEP 491 convention"#4766
Conversation
|
Thank you! The failing test seems to be happening now regardless of this change: https://github.com/pypa/setuptools/actions/runs/12298183072/job/34321035714#step:3:49. I don't know if anything changed in the latest versions of Python being distributed to macOS, so that |
|
Aha, that's a different failure actually, |
abravalheri
force-pushed
the
fix/3777
branch
from
92d42d1 to
c1bf7c7
Compare
This looks like it is checking deprecated functionality? Not sure we have to account such an edge case since we are moving away from |
|
I'm not sure! I think the test is just broken in a way I haven't been able to figure out (it mixes the distribution name and the namespace name as one thing in the helper functions) but I think the underlying functionality probably still works? |
|
All tests are passing, this is now ready for review. |
jaraco
left a comment
jaraco
left a comment
There was a problem hiding this comment.
It doesn't make me happy to approve this change, but I've conceded the fight. Let's align with the spec.
|
This is ready for re-review. |
**Context:** setuptools has had a release recently that normalizes package names: References: - pypa/setuptools#4766 - https://packaging.python.org/en/latest/specifications/name-normalization/#name-normalization **Description of the Change:** Due setuptools 75.8.0 and 75.8.1 outputting completely different package names, we cannot support both, so CI now "pins" to >=75.8.1. **Benefits:** Fix CI failures. **Possible Drawbacks:** We may need to update docs. This is also another situation where moving away from setup.py to pyproject would yield benefits. As then you can specify the minimum setuptools version as part of the build-backend configuration. **Related GitHub Issues:** None. [sc-85195](https://app.shortcut.com/xanaduai/story/85195/investigate-issue-with-pennylane-ci-failing-with-uv-build-outputting-package-that-doesn-t-match-name-in-setup-py)
Fix "Wheel naming is not following PEP 491 convention"
Same reason as for #2380 This makes $UNIQUE_NAME usable in PyPI distribution names, which are lowercased: pypa/setuptools#4766
Same reason as for #2380 This makes $UNIQUE_NAME usable in PyPI distribution names, which are lowercased: pypa/setuptools#4766
In pypa/setuptools#4766 the `.dist-info` directory name was normalized to conform to PEP 491, which broke content introspection for Python packages. Adapt some of the normalization from setuptools to match.
In pypa/setuptools#4766 the `.dist-info` directory name was normalized to conform to PEP 491, which broke content introspection for Python packages. Adapt some of the normalization from setuptools to match.
4 participants
Summary of changes
Fixes #3777.
Marking this as draft as there is one outstanding failing test that I have been unable to resolve (setuptools/tests/test_easy_install.py::TestSetupRequires::test_setup_requires_override_nspkg).Pull Request Checklist
newsfragments/.(See documentation for details)