Fix wheel name normalization in tests#13246
Merged
Conversation
notatallshaw
approved these changes
Feb 26, 2025
ichard26
approved these changes
Feb 26, 2025
Member
ichard26
left a comment
ichard26
left a comment
There was a problem hiding this comment.
Thanks a ton for fixing our tests for us! ❤️
notatallshaw
pushed a commit
to notatallshaw/pip
that referenced
this pull request
Feb 27, 2025
Setuptools v75.8.1 normalizes the filenames of the wheels it produces in compliance with a "recent" change in the wheel specification. This also applies to the .dist-info directories.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes tests with non-normalized filenames that started failing as a result of pypa/setuptools#4766.