PR from abrombo/galgebra:master for reference (with merge conflicts solved) by eric-wieser · Pull Request #62 · pygae/galgebra

eric-wieser · 2019-11-21T14:53:33Z

A variant of #52 containing the ~~(trivial)~~ manual merge(s) needed to make the diff readable

function (overloaded print function). Added function xtex to printer for displaying LaTeX output. For example the call xtex(tex='texmaker') invokes the 'texmaker' program (if installed) with the tex output file. The is useful for debugging incorrect LaTeX output. Replaced sympy collect function with custom Collect so that tests work with sympy 1.4. Worked through most of jupyter notebook and LaTeX examples with new python 3 compatible printing in printing.py. Also added comments to functions that needed explainations. Still much more to do on that task.

and Sdop when either is multiplied by (left multiplication) a multivector resulting in a Dop. Signed-off-by: Alan Bromborsky <abrombo999@gmail.com>

eric-wieser · 2019-11-21T17:16:50Z

Created https://github.com/abrombo/galgebra/pull/2 to get this merge into @abrombo's hands

eric-wieser · 2019-12-04T18:35:33Z

+    def odot(self,dot_flg=True):
+        new_self = copy.deepcopy(self)
+        new_self.dot_flg = dot_flg
+        return new_self


This is the only change to the differential operators part of this file (xref gh-133)

These are files that were either created temporarily for testing, or were accidentally restored from a much older version.

The comment in ga.py is just copied from the sympy docs. The one in metric is self-explanatory.

This was errantly removed by me in a previous commit, I think

lgtm-com · 2020-04-22T14:55:01Z

This pull request introduces 6 alerts and fixes 1 when merging 3182784 into 409bb90 - view on LGTM.com

new alerts:

5 for Unused local variable
1 for Module imports itself

fixed alerts:

1 for Unused local variable

lgtm-com · 2020-04-22T15:13:36Z

This pull request introduces 6 alerts and fixes 1 when merging 7988e73 into 409bb90 - view on LGTM.com

new alerts:

5 for Unused local variable
1 for Module imports itself

fixed alerts:

1 for Unused local variable

eric-wieser · 2020-04-23T10:16:11Z

Rebased with some flake8 fixes and removals of stray files.

I think all that's really in here now is an incomplete odot implementation, and the printer stuff.

lgtm-com · 2020-04-23T10:31:37Z

This pull request introduces 6 alerts and fixes 1 when merging bfeaddb into 46cde16 - view on LGTM.com

new alerts:

5 for Unused local variable
1 for Module imports itself

fixed alerts:

1 for Unused local variable

lgtm-com · 2020-04-25T22:15:04Z

This pull request introduces 6 alerts and fixes 1 when merging 9f8a1ec into ce2daf8 - view on LGTM.com

new alerts:

5 for Unused local variable
1 for Module imports itself

fixed alerts:

1 for Unused local variable

eric-wieser · 2020-04-29T10:36:13Z

+            from IPython.core.interactiveshell import InteractiveShell
+            #  Allow multiple outputs in an output cell
+            #  https://forums.fast.ai/t/jupyter-notebook-enhancements-tips-and-tricks/17064/2
+            InteractiveShell.ast_node_interactivity = "all"


This isn't about allowing multiple outputs, it's about producing them automatically.
The user can always print multiple outputs with display(...) if they want to.

This doesn't seem like a good idea to me. If users want it, they can do it themselves.

lgtm-com · 2020-04-29T10:36:45Z

This pull request introduces 6 alerts and fixes 1 when merging 1234445 into 421449b - view on LGTM.com

new alerts:

5 for Unused local variable
1 for Module imports itself

fixed alerts:

1 for Unused local variable

eric-wieser · 2020-04-29T10:37:54Z

+    if isinstance(s[0], str):
+
+        if s[0] == 'h':
+            GaLatexPrinter.fmt_dict['h'] = True
+            s = s[1:]


This looks like a bad idea to me. This changes the behavior of print(my_str) to print nothing at all if my_str == 'h'!

eric-wieser · 2020-05-15T10:45:55Z

Conflicts solved again

lgtm-com · 2020-05-15T11:00:23Z

This pull request introduces 6 alerts when merging 448edf0 into 5108d16 - view on LGTM.com

new alerts:

4 for Unused local variable
1 for Module imports itself
1 for Unused import

codecov · 2020-05-15T11:08:13Z

Codecov Report

Merging #62 into master will decrease coverage by 1.70%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master      #62      +/-   ##
==========================================
- Coverage   77.56%   75.86%   -1.71%     
==========================================
  Files          16       16              
  Lines        4217     4495     +278     
==========================================
+ Hits         3271     3410     +139     
- Misses        946     1085     +139

Impacted Files	Coverage Δ
galgebra/printer.py	`71.73% <0.00%> (-6.90%)`	⬇️
galgebra/dop.py	`88.52% <0.00%> (-2.55%)`	⬇️
galgebra/lt.py	`57.61% <0.00%> (-1.69%)`	⬇️
galgebra/atoms.py	`97.33% <0.00%> (-0.35%)`	⬇️
galgebra/ga.py	`80.64% <0.00%> (-0.13%)`	⬇️
galgebra/metric.py	`76.04% <0.00%> (-0.12%)`	⬇️
galgebra/deprecated.py	`100.00% <0.00%> (ø)`
galgebra/mv.py	`74.91% <0.00%> (+<0.01%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7f57a09...76315e4. Read the comment docs.

lgtm-com · 2020-05-15T11:18:32Z

This pull request introduces 6 alerts when merging 9aa5005 into 5108d16 - view on LGTM.com

new alerts:

4 for Unused local variable
1 for Module imports itself
1 for Unused import

eric-wieser · 2020-05-17T09:56:31Z

 \newcommand{\lbrc}{\left \{}
-\newcommand{\rbrc}{\right \}}
+\newcommand{\rbrc}{\right \]}
+\newcommand{\lbrk}{\left \[}
+\newcommand{\rbrk}{\right \}}


@brombo, this looks to me like a bug?

Yeah, obviously

lgtm-com · 2020-05-17T10:12:06Z

This pull request introduces 5 alerts when merging 309bbd7 into f6452ab - view on LGTM.com

new alerts:

4 for Unused local variable
1 for Unused import

…master-merge # Conflicts: # examples/ipython/dop.ipynb # examples/ipython/gr_metrics.ipynb # galgebra/printer.py

…master-merge # Conflicts: # examples/LaTeX/Dop.py # examples/LaTeX/christoffel_symbols.py # examples/LaTeX/colored_christoffel_symbols.py # examples/ipython/colored_christoffel_symbols.ipynb # examples/ipython/inner_product.ipynb # examples/ipython/second_derivative.ipynb # examples/ipython/st4.ipynb # galgebra/printer.py

# Conflicts: # examples/ipython/tutorial_algebra.ipynb # galgebra/mv.py # galgebra/printer.py

lgtm-com · 2020-05-26T09:54:34Z

This pull request introduces 5 alerts when merging 76315e4 into 09d882f - view on LGTM.com

new alerts:

4 for Unused local variable
1 for Unused import

utensil · 2024-05-15T02:35:07Z

Thank you @abrombo @eric-wieser , this should be superseded by #510 which merged gprinter from upstream. Feel free to reopen if there are remaining issues.

abrombo and others added 3 commits October 11, 2019 14:13

Added comments to several modules and fixed problems in mv.py for Pdop

d8a1661

and Sdop when either is multiplied by (left multiplication) a multivector resulting in a Dop. Signed-off-by: Alan Bromborsky <abrombo999@gmail.com>

Remove executable bits that were erroneously added in the last commits

d802096

eric-wieser mentioned this pull request Nov 21, 2019

PR from abrombo/galgebra:master for reference #52

Closed

utensil mentioned this pull request Nov 29, 2019

Merge features from abrombo's branch #88

Open

eric-wieser commented Dec 4, 2019

View reviewed changes

eric-wieser added 4 commits April 21, 2020 09:42

Delete some unwanted files

0f0c3ad

These are files that were either created temporarily for testing, or were accidentally restored from a much older version.

Merge remote-tracking branch 'upstream/master' into abrombo-master-merge

6727464

Merge remote-tracking branch 'upstream/master' into abrombo-master-merge

7184d82

Merge remote-tracking branch 'upstream/master' into abrombo-master-merge

7bf587e

eric-wieser force-pushed the abrombo-master-merge branch from 018bb9f to 7bf587e Compare April 22, 2020 14:32

eric-wieser added 2 commits April 22, 2020 15:39

Revert some unwanted changes

3182784

The comment in ga.py is just copied from the sympy docs. The one in metric is self-explanatory.

Add back the executable bit

7988e73

This was errantly removed by me in a previous commit, I think

eric-wieser added 2 commits April 23, 2020 11:11

Merge remote-tracking branch 'upstream/master' into abrombo-master-merge

c811dac

Fix flake8 issues

bfeaddb

eric-wieser mentioned this pull request Apr 24, 2020

Add support for passing other forms of argument to Mv.subs #243

Merged

eric-wieser commented Apr 24, 2020

View reviewed changes

Comment thread galgebra/mv.py Outdated

Merge remote-tracking branch 'upstream/master' into abrombo-master-merge

9f8a1ec

eric-wieser mentioned this pull request Apr 29, 2020

Remove Mv.Format, Mv.latex_flg, and Mv.restore #261

Merged

Move methods down to reduce the overall diff

1234445

eric-wieser commented Apr 29, 2020

View reviewed changes

eric-wieser added the component: printer string, latex, and ansi escape printing label Apr 30, 2020

Remove commented-out code

956e006

Merge remote-tracking branch 'upstream/master' into abrombo-master-merge

9aa5005

eric-wieser force-pushed the abrombo-master-merge branch from 448edf0 to 9aa5005 Compare May 15, 2020 11:03

This was referenced May 15, 2020

Use a raw string for printer.ip_cmds #342

Merged

Remove a pointless docstring that is not attached to anything #343

Merged

eric-wieser added 2 commits May 17, 2020 10:46

Merge remote-tracking branch 'upstream/master' into abrombo-master-merge

c676643

Remove self-import flagged by LGTM

309bbd7

eric-wieser commented May 17, 2020

View reviewed changes

eric-wieser added 3 commits May 26, 2020 10:29

Merge commit '677360f1b5d5b4b4cdb3e5da9731fc9198f89f20' into abrombo-…

6fca038

…master-merge # Conflicts: # examples/ipython/dop.ipynb # examples/ipython/gr_metrics.ipynb # galgebra/printer.py

Merge remote-tracking branch 'upstream/master' into abrombo-master-merge

76315e4

# Conflicts: # examples/ipython/tutorial_algebra.ipynb # galgebra/mv.py # galgebra/printer.py

utensil added this to the 0.6.0 milestone May 15, 2024

utensil closed this May 15, 2024

Conversation

eric-wieser commented Nov 21, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

eric-wieser commented Nov 21, 2019

Uh oh!

eric-wieser Dec 4, 2019

Choose a reason for hiding this comment

Uh oh!

lgtm-com bot commented Apr 22, 2020

Uh oh!

lgtm-com bot commented Apr 22, 2020

Uh oh!

eric-wieser commented Apr 23, 2020

Uh oh!

lgtm-com bot commented Apr 23, 2020

Uh oh!

Uh oh!

lgtm-com bot commented Apr 25, 2020

Uh oh!

eric-wieser Apr 29, 2020

Choose a reason for hiding this comment

Uh oh!

lgtm-com bot commented Apr 29, 2020

Uh oh!

eric-wieser Apr 29, 2020

Choose a reason for hiding this comment

Uh oh!

eric-wieser commented May 15, 2020

Uh oh!

lgtm-com bot commented May 15, 2020

Uh oh!

codecov bot commented May 15, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

lgtm-com bot commented May 15, 2020

Uh oh!

eric-wieser May 17, 2020

Choose a reason for hiding this comment

Uh oh!

utensil May 17, 2020

Choose a reason for hiding this comment

Uh oh!

lgtm-com bot commented May 17, 2020

Uh oh!

lgtm-com bot commented May 26, 2020

Uh oh!

utensil commented May 15, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

eric-wieser commented Nov 21, 2019 •

edited

Loading

codecov bot commented May 15, 2020 •

edited

Loading