Sync updates from upstream, particularly GSG's work#510
Conversation
These changes are just additions, causing no conflict with existing code. Markers like `GSG code starts/ends` are kept to make it easier to identify the added code and distinguish it with other changes between 0.5.0 and 0.5.1, as well as GSG's other proposed changes. Co-authored-by: Greg Grunberg <g.s.grunberg@gmail.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #510 +/- ##
==========================================
+ Coverage 78.05% 78.95% +0.90%
==========================================
Files 17 19 +2
Lines 4196 4400 +204
==========================================
+ Hits 3275 3474 +199
- Misses 921 926 +5 ☔ View full report in Codecov by Sentry. |
Removed code conflicting about `Matrix_to_dictionary` and `inspect.getfullargspec`. Co-authored-by: Greg Grunberg <g.s.grunberg@gmail.com>
|
CI is green for |
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
|
The changes to test outputs of
The changes to test outputs of
Will investigate later. The current green CI is a delusion for now. The visual diff is at: https://app.reviewnb.com/pygae/galgebra/commit/33a33fbefc67a480e7f0565273cc16b0e34f8d09/ |
Co-authored-by: Alan Bromborsky <abrombo@users.noreply.github.com>
Co-authored-by: Greg Grunberg <g.s.grunberg@gmail.com>
They are put into examples/primer, and `GAlgebraOutput.ipynb` is renamed to `gprint.ipynb`, and the rest are ensured to be in lowercase. Co-authored-by: Greg Grunberg <g.s.grunberg@gmail.com>
Upstream Macdonald code requires F(basis) to return a non-zero vector. The is_zero() exemption added in pygae#510 allows degenerate/singular maps through silently; restoring the stricter check makes the error explicit.



Addresses #505 .
This PR aims to:
GSG code starts/endswill be kept to make it easier to identify the added code and distinguish it with other changes between 0.5.0 and 0.5.1, as well as GSG's other proposed changesadd documentations for new APIs(there are basic docs, I choose to use follow-up PRs to improve)The goal here is to make it a foundation for merging other people's work, and avoid accidentally rolling back previous work (check v0.5.0...v0.5.1 to decide what to keep when there is code conflict).
The strategy is to add them and fix them file by file.
TODOs:
mvltgprinterGAlgebraInit(renamed toprimer)GAlgebraOutput.ipynbis renamed togprint.ipynb, and the rest are ensured to be in lowercase.)lin_tran_checktest_gsg_undual_etc.ipynb