-
Notifications
You must be signed in to change notification settings - Fork 58
Sizing, spacing and typography design tokens #297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/primer/primitives/88AZA9fJpkgBxfvNZUSRve9Zg92j |
Variables changedNo variables changed |
Co-authored-by: Vinicius Depizzol <vdepizzol@gmail.com>
rezrah
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🥳 This is great @langermank
Recommend this gets merged into main so we can continue to iterate on it in shorter-lived branches. Merging shouldn't impact the release process for existing tokens.
✨ New sizing, spacing, and typography design tokens
This PR introduces a new set of tokens to be shared across all Primer frameworks. Using style-dictionary, we transform raw values from JSON into CSS and JS. We've crafted a functional layer of tokens that combine to form components and patterns, along with a naming convention to encourage consistency and developer experience.
Initial release
The existing tokens will remain intact as we slowly transition to style-dictionary. This new set of tokens will distribute to
/tokens-v2-privateas they are still experimental and not intended for usage outside of Primer (for now). This PR should not introduce any breaking changes to existing primitives.Remaining TODO