Implement bare-bones Hero component
#6
Conversation
|
| Blazing fast cloud | ||
| <br /> | ||
| developer environments | ||
| </> |
There was a problem hiding this comment.
heading and description accept a string or a React element to allow marketing to control linebreaks if necessary
There was a problem hiding this comment.
ahh that makes sense.. great idea 👍
There was a problem hiding this comment.
A potential downside to markup-based linebreaks could be responsive behaviour? Would it be better to recommend granular control via css instead?
There was a problem hiding this comment.
A potential downside to markup-based linebreaks could be responsive behaviour? Would it be better to recommend granular control via css instead?
Maybe. We use linebreaks in other marketing sites so I wanted to enable that for now. But I'm open to changing this if we find a better CSS solution later.
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://green-tree-0cc944a10-6.centralus.1.azurestaticapps.net |
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://green-tree-0cc944a10-6.centralus.1.azurestaticapps.net |
| type Props = { | ||
| children: React.ReactNode | ||
| export type HeroProps = { | ||
| heading: string | React.ReactElement |
There was a problem hiding this comment.
Could you use React.ReactNode instead, which should cover both?
There was a problem hiding this comment.
I didn't use ReactNode because it includes a lot of types that don't make sense for heading
|
@colebemis I have a test |
Summary
Implements a bare-bones
Herocomponent.Next steps
Tracked in https://github.com/github/primer/issues/747