Closed
Conversation
Generate changelog in
|
Contributor
Author
|
Going to close this out for now, will reopen if needed |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before this PR
LOG4J2-3560 is triggering significant allocations on calls to
Logger#isDebugEnabled()such as fromTracer#logClearingTrace()tracing-java/tracing/src/main/java/com/palantir/tracing/Tracer.java
Lines 911 to 926 in e7da94d
Long term upstream fix for log4j is proposed as apache/logging-log4j2#974 ; however, we may want to consider removing
Tracer#logClearingTrace()in the interim as it impacts services that heavily utilize tracing, such as timelock & atlasdb'sAwaitingLeadershipProxyAfter this PR
==COMMIT_MSG==
Remove Tracer#logClearingTrace()
==COMMIT_MSG==
Possible downsides?
We lose the debug & trace logging @tpetracca added in #678 though I don't think this is used often if ever.