Conversation
This comment has been minimized.
This comment has been minimized.
carterkozak
reviewed
Jan 20, 2021
| } | ||
|
|
||
| private static void logClearingTrace() { | ||
| log.debug("Clearing current trace", SafeArg.of("maybeTrace", Optional.ofNullable(currentTrace.get()))); |
Contributor
There was a problem hiding this comment.
nit: Let's wrap this with log.isDebugEnabled to prevent optional and safeArg allocations when debug logging is disabled.
note: no reason to use an Optional for the safe-arg, as far as the logging system is concerned empty optional and null are indistinguishable.
Contributor
There was a problem hiding this comment.
While we're here, thoughts on mirroring the debug line after a traceId is set? That way we get a full sense of the scope transitions.
carterkozak
approved these changes
Jan 21, 2021
Contributor
carterkozak
left a comment
carterkozak
left a comment
There was a problem hiding this comment.
oof, I never submitted comments. Sorry for the delay!
Approving, change looks good to me. Up to you whether you'd like to take action on the nits.
tpetracca
force-pushed
the
tp/log-on-trace-clear
branch
from
f41e2e7 to
f3ec634
Compare
Collaborator
|
Released 4.11.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We're seeing instances of trace information disappearing from logs on a thread that previously had traceIds. Trying to track down where/how they're getting cleared.
==COMMIT_MSG==
debug logging when clearing trace
==COMMIT_MSG==