Skip to content

OCPBUGS-77412: reload router if route is changed on DCM #739

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jcmoraisjr wants to merge 1 commit into
base: master
Choose a base branch
from
+14 −0
Open

OCPBUGS-77412: reload router if route is changed on DCM #739

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions pkg/router/template/router.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -788,6 +788,13 @@ func (r *templateRouter) dynamicallyAddRoute(backendKey ServiceAliasConfigKey, r
log.V(4).Info("dynamically adding route backend", "backendKey", backendKey)
r.dynamicConfigManager.Register(backendKey, route)

// Fully skipping DCM for now when adding or changing routes,
// should be reincluded along with the fix for https://issues.redhat.com/browse/OCPBUGS-77344
// Returning from within an always true condition makes linter happy.
if true {
return false
}

// If no initial sync was done, don't try to dynamically add the
// route as we will need a reload anyway.
if !r.synced {
Expand Down Expand Up @@ -830,6 +837,13 @@ func (r *templateRouter) dynamicallyAddRoute(backendKey ServiceAliasConfigKey, r
// Note: The config should have been synced at least once initially and
// the caller needs to acquire a lock [and release it].
func (r *templateRouter) dynamicallyRemoveRoute(backendKey ServiceAliasConfigKey, route *routev1.Route) bool {
// Fully skipping DCM for now when adding or changing routes,
// should be reincluded along with the fix for https://issues.redhat.com/browse/OCPBUGS-77344
// Returning from within an always true condition makes linter happy.
if true {
return false
}

if r.dynamicConfigManager == nil || !r.synced {
return false
}
Expand Down