OCPBUGS-77412: reload router if route is changed on DCM

[jcmoraisjr]

DCM (dynamic update) is removing+adding routes whenever they change. This causes disruption on the changed route, and can cause a longer outage in case the API call to add the route fails.

This update is skipping the dynamic update in case of any route change, either creation, change and deletion. This is the simplest approach for the current release, a proper fix on the API calls should be done post 4.22 in the scope of https://issues.redhat.com/browse/OCPBUGS-77344

The dynamic update skip is being added just after the route registration on the AddRoute method, this ensures that the free slots can be found in case of scale out. If skipping the registration, the free slots cannot be found and scale in/out would force a reload.

[openshift-ci-robot]

@jcmoraisjr: This pull request references Jira Issue OCPBUGS-77412, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.22.0) matches configured target version for branch (4.22.0)
• bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @ShudiLi

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

DCM (dynamic update) is removing+adding routes whenever they change. This causes disruption on the changed route, and can cause a longer outage in case the API call to add the route fails.

This update is skipping the dynamic update in case of any route change, either creation, change and deletion. This is the simplest approach for the current release, a proper fix on the API calls should be done post 4.22 in the scope of https://issues.redhat.com/browse/OCPBUGS-77412

The dynamic update skip is being added just after the route registration on the AddRoute method, this ensures that the free slots can be found in case of scale out. If skipping the registration, the free slots cannot be found and scale in/out would force a reload.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign jcmoraisjr for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

@jcmoraisjr: This pull request references Jira Issue OCPBUGS-77412, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.22.0) matches configured target version for branch (4.22.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @ShudiLi

Details

In response to this:

DCM (dynamic update) is removing+adding routes whenever they change. This causes disruption on the changed route, and can cause a longer outage in case the API call to add the route fails.

This update is skipping the dynamic update in case of any route change, either creation, change and deletion. This is the simplest approach for the current release, a proper fix on the API calls should be done post 4.22 in the scope of https://issues.redhat.com/browse/OCPBUGS-77344

The dynamic update skip is being added just after the route registration on the AddRoute method, this ensures that the free slots can be found in case of scale out. If skipping the registration, the free slots cannot be found and scale in/out would force a reload.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

@jcmoraisjr: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[ShudiLi]

tested it with 4.22.0-0-2026-02-27-012336-test-ci-ln-y144372-latest

1.
% oc get clusterversion
NAME      VERSION                                                AVAILABLE   PROGRESSING   SINCE   STATUS
version   4.22.0-0-2026-02-27-012336-test-ci-ln-y144372-latest   True        False         28m     Cluster version is 4.22.0-0-2026-02-27-012336-test-ci-ln-y144372-latest

2.
 % oc -n openshift-ingress get deploy/router-default -oyaml | grep -A1 "/usr/bin/openshift-router"
        - /usr/bin/openshift-router
        - --v=5

3.
% oc get route
NAME           HOST/PORT                                                              PATH   SERVICES                                               PORT          TERMINATION   WILDCARD
unsec-route2   unsec-route2-default.apps.ci-ln-y144372-76ef8.aws-4.ci.openshift.org          unsec-apach(42%),unsec-apach2(28%),unsec-apach3(28%)   unsec-apach                 None

4.
% oc get deployment 
NAME             READY   UP-TO-DATE   AVAILABLE   AGE
appach-server    2/2     2            2           32m
appach-server2   2/2     2            2           32m
appach-server3   2/2     2            2           32m

5.
 % oc -n openshift-ingress rsh router-default-b7864749c-646s9
sh-5.1$ echo show info | socat - /var/lib/haproxy/run/haproxy.sock |grep Pid
Pid: 89

6. scale up/down deployments
 % oc scale deployment appach-server  --replicas=3
deployment.apps/appach-server scaled
 % oc scale deployment appach-server  --replicas=1            
deployment.apps/appach-server scaled
 % oc scale deployment appach-server2  --replicas=3
deployment.apps/appach-server2 scaled
% oc scale deployment appach-server3  --replicas=3
deployment.apps/appach-server3 scaled
% oc get deployment 
NAME             READY   UP-TO-DATE   AVAILABLE   AGE
appach-server    1/1     1            1           34m
appach-server2   3/3     3            3           34m
appach-server3   3/3     3            3           34m

7. Check the router pod logs
% oc -n openshift-ingress logs router-default-b7864749c-646s9 | grep map | grep add 
% oc -n openshift-ingress logs router-default-b7864749c-646s9 | grep map | grep del
%

8. Check the Pid, which wasn't changed as expected
% oc -n openshift-ingress rsh router-default-b7864749c-646s9 
sh-5.1$ echo show info | socat - /var/lib/haproxy/run/haproxy.sock |grep Pid
Pid: 89

[ShudiLi]

/label qe-approved
/verified by @ShudiLi

[openshift-ci-robot]

@ShudiLi: This PR has been marked as verified by @ShudiLi.

Details

In response to this:

/label qe-approved
/verified by @ShudiLi

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.