-
Notifications
You must be signed in to change notification settings - Fork 8.7k
Add model availability NUX tooltips #13021
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
4c051d3
Add model availability NUX tooltips
aibrahim-oai 6bd76b2
Flatten model availability NUX config
aibrahim-oai e8b0544
codex: fix CI failure on PR #13021
aibrahim-oai 545c24a
codex: address PR review feedback (#13021)
aibrahim-oai 858f3ee
codex: fix CI failure on PR #13021
aibrahim-oai 7b99710
codex: fix CI failure on PR #13021
aibrahim-oai 4d4897c
Merge branch 'main' into codex/model-availability-nux-tooltips
aibrahim-oai 958fd8f
tui: add e2e test for resume nux counts
aibrahim-oai File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
model_availability_nux_count_editsclearstui.model_availability_nuxand rewrites every key. Combined with startup code that builds updates from an in-memory snapshot, concurrent Codex launches can clobber each other's increments (lost update). This breaks the 4-exposure cap by regressing or dropping per-model counters.Useful? React with 👍 / 👎.