Skip to content

Add model availability NUX tooltips#13021

Merged
aibrahim-oai merged 8 commits intomainfrom
codex/model-availability-nux-tooltips
Feb 28, 2026
Merged

Add model availability NUX tooltips#13021
aibrahim-oai merged 8 commits intomainfrom
codex/model-availability-nux-tooltips

Conversation

@aibrahim-oai
Copy link
Collaborator

@aibrahim-oai aibrahim-oai commented Feb 27, 2026

  • override startup tooltips with model availability NUX and persist per-model show counts in config
  • stop showing each model after four exposures and fall back to normal tooltips

@aibrahim-oai
Copy link
Collaborator Author

@codex review

Copy link
Contributor

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 6bd76b27aa

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@aibrahim-oai
Copy link
Collaborator Author

@codex review

Copy link
Contributor

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 4d4897c47b

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +83 to +85
let mut edits = vec![ConfigEdit::ClearPath {
segments: vec!["tui".to_string(), "model_availability_nux".to_string()],
}];
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Avoid rewriting the full NUX map from stale state

model_availability_nux_count_edits clears tui.model_availability_nux and rewrites every key. Combined with startup code that builds updates from an in-memory snapshot, concurrent Codex launches can clobber each other's increments (lost update). This breaks the 4-exposure cap by regressing or dropping per-model counters.

Useful? React with 👍 / 👎.

Copy link
Collaborator

@sayan-oai sayan-oai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

integration tests?

@aibrahim-oai
Copy link
Collaborator Author

@codex can you add e2e integration test?

@chatgpt-codex-connector
Copy link
Contributor

Summary

Testing

  • just fmt
  • cargo test -p codex-tui --test all suite::model_availability_nux::resume_startup_does_not_consume_model_availability_nux_count -- --exact
  • cargo test -p codex-tui

View task →

@aibrahim-oai aibrahim-oai merged commit ec6f6aa into main Feb 28, 2026
27 of 31 checks passed
@aibrahim-oai aibrahim-oai deleted the codex/model-availability-nux-tooltips branch February 28, 2026 01:14
@github-actions github-actions bot locked and limited conversation to collaborators Feb 28, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants