Skip to content

Conversation

@ghost
Copy link

@ghost ghost commented Aug 28, 2024

Release

This would mean tagging a6ca9ee as v1.2.0 to release.

Vote

We need at least 4 approvals from 6 maintainers to release notation-go v1.2.0.

What's Changed

Full Changelog:
v1.2.0-rc.1...a6ca9ee

Actions

Please review the PR and vote by approving.

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
@codecov
Copy link

codecov bot commented Aug 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.21%. Comparing base (7260694) to head (a6ca9ee).
Report is 2 commits behind head on release-1.2.

Additional details and impacted files
@@             Coverage Diff              @@
##           release-1.2     #445   +/-   ##
============================================
  Coverage        81.21%   81.21%           
============================================
  Files               32       32           
  Lines             2279     2279           
============================================
  Hits              1851     1851           
  Misses             299      299           
  Partials           129      129           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ghost
Copy link
Author

ghost commented Aug 28, 2024

LGTM

1 similar comment
@JeyJeyGao
Copy link
Contributor

LGTM

Copy link
Contributor

@JeyJeyGao JeyJeyGao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@priteshbandi priteshbandi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ghost ghost merged commit 07b2508 into notaryproject:release-1.2 Aug 28, 2024
@ghost ghost deleted the release-1.2 branch August 28, 2024 06:20
@ghost ghost mentioned this pull request Sep 5, 2024
6 tasks
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants