Skip to content

Conversation

@ghost
Copy link

@ghost ghost commented Aug 27, 2024

No description provided.

dependabot bot and others added 4 commits August 27, 2024 13:49
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
@codecov
Copy link

codecov bot commented Aug 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.21%. Comparing base (a83c5be) to head (99c0c44).
Report is 1 commits behind head on release-1.2.

Additional details and impacted files
@@             Coverage Diff              @@
##           release-1.2     #442   +/-   ##
============================================
  Coverage        81.21%   81.21%           
============================================
  Files               32       32           
  Lines             2279     2279           
============================================
  Hits              1851     1851           
  Misses             299      299           
  Partials           129      129           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JeyJeyGao
Copy link
Contributor

Will we include #434 and #433 in this PR? or They will be another PR.

@ghost
Copy link
Author

ghost commented Aug 27, 2024

Will we include #434 and #433 in this PR? or They will be another PR.

They are cherry picked and included in this PR.

JeyJeyGao
JeyJeyGao previously approved these changes Aug 27, 2024
Copy link
Contributor

@JeyJeyGao JeyJeyGao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
@ghost ghost requested review from JeyJeyGao and shizhMSFT August 27, 2024 07:15
@ghost ghost changed the title bump: release v1.2.0 bump: bump up for v1.2.0 release Aug 27, 2024
Copy link
Contributor

@JeyJeyGao JeyJeyGao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@priteshbandi priteshbandi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ghost ghost merged commit 7260694 into notaryproject:release-1.2 Aug 28, 2024
@ghost ghost deleted the release-1.2 branch August 28, 2024 00:54
@ghost ghost mentioned this pull request Aug 28, 2024
6 tasks
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants