fix: do not use the router in the store #2362
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #2362 +/- ##
==========================================
- Coverage 26.53% 26.51% -0.02%
==========================================
Files 62 63 +1
Lines 3068 3070 +2
Branches 681 683 +2
==========================================
Hits 814 814
- Misses 2254 2256 +2 |
Signed-off-by: Raimund Schlüßler <raimund.schluessler@mailbox.org>
raimund-schluessler
force-pushed
the
fix/noid/store-router
branch
from
ff76cbe to
7efcbaf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the usage of
routerin the store. This prevents initializing the router if only the store is used.As a side-effect, the bundles for
talkanddashboarddecreased in size by1.3 MB.Supersedes #2346.